You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2022/05/25 00:01:13 UTC

Review Request 73999: RANGER:3777 Execute permissions required in init scripts to run containers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73999/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3777
    https://issues.apache.org/jira/browse/RANGER-3777


Repository: ranger


Description
-------

The init scripts inside dev-support/ranger-docker/scripts do not have execute permissions for owner. 
Currently ranger and dependent services containers are failing due to absense of required permissions.


The patch also brings in changes from RANGER-3738 to ranger-2.3.


Diffs
-----

  dev-support/ranger-docker/Dockerfile.ranger b11e72666 
  dev-support/ranger-docker/Dockerfile.ranger-hadoop f25bc0d8d 
  dev-support/ranger-docker/Dockerfile.ranger-hbase 5a2f056a9 
  dev-support/ranger-docker/Dockerfile.ranger-hive 31afe33d9 
  dev-support/ranger-docker/Dockerfile.ranger-kafka 83c41b277 
  dev-support/ranger-docker/Dockerfile.ranger-knox bc78af9cc 
  dev-support/ranger-docker/Dockerfile.ranger-tagsync 28dadd424 
  dev-support/ranger-docker/Dockerfile.ranger-usersync ba7859ede 
  dev-support/ranger-docker/README.md 248ab1fc9 


Diff: https://reviews.apache.org/r/73999/diff/1/


Testing
-------

Tested locally.


Thanks,

Abhishek  Kumar


Re: Review Request 73999: RANGER:3777 Execute permissions required in init scripts to run containers

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73999/#review224463
-----------------------------------------------------------




dev-support/ranger-docker/README.md
Lines 31 (patched)
<https://reviews.apache.org/r/73999/#comment313244>

    Steps #3 and #4 are covered by #5 earlier. Earlier approach enables building Ranger in a clean build env i.e.. with sources from specific branch by ignoring changes in local git repo (by setting BUILD_HOST_SRC=false).
    
    I think the new steps can be added as an option in README, but shouldn't replace existing one.


- Madhan Neethiraj


On May 25, 2022, 12:01 a.m., Abhishek  Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73999/
> -----------------------------------------------------------
> 
> (Updated May 25, 2022, 12:01 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3777
>     https://issues.apache.org/jira/browse/RANGER-3777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The init scripts inside dev-support/ranger-docker/scripts do not have execute permissions for owner. 
> Currently ranger and dependent services containers are failing due to absense of required permissions.
> 
> 
> The patch also brings in changes from RANGER-3738 to ranger-2.3.
> 
> 
> Diffs
> -----
> 
>   dev-support/ranger-docker/Dockerfile.ranger b11e72666 
>   dev-support/ranger-docker/Dockerfile.ranger-hadoop f25bc0d8d 
>   dev-support/ranger-docker/Dockerfile.ranger-hbase 5a2f056a9 
>   dev-support/ranger-docker/Dockerfile.ranger-hive 31afe33d9 
>   dev-support/ranger-docker/Dockerfile.ranger-kafka 83c41b277 
>   dev-support/ranger-docker/Dockerfile.ranger-knox bc78af9cc 
>   dev-support/ranger-docker/Dockerfile.ranger-tagsync 28dadd424 
>   dev-support/ranger-docker/Dockerfile.ranger-usersync ba7859ede 
>   dev-support/ranger-docker/README.md 248ab1fc9 
> 
> 
> Diff: https://reviews.apache.org/r/73999/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Abhishek  Kumar
> 
>


Re: Review Request 73999: RANGER:3777 Execute permissions required in init scripts to run containers

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73999/#review224464
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 25, 2022, 3:02 a.m., Abhishek  Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73999/
> -----------------------------------------------------------
> 
> (Updated May 25, 2022, 3:02 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3777
>     https://issues.apache.org/jira/browse/RANGER-3777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The init scripts inside dev-support/ranger-docker/scripts do not have execute permissions for owner. 
> Currently ranger and dependent services containers are failing due to absense of required permissions.
> 
> 
> The patch also brings in changes from RANGER-3738 to ranger-2.3.
> 
> 
> Diffs
> -----
> 
>   dev-support/ranger-docker/Dockerfile.ranger b11e72666 
>   dev-support/ranger-docker/Dockerfile.ranger-hadoop f25bc0d8d 
>   dev-support/ranger-docker/Dockerfile.ranger-hbase 5a2f056a9 
>   dev-support/ranger-docker/Dockerfile.ranger-hive 31afe33d9 
>   dev-support/ranger-docker/Dockerfile.ranger-kafka 83c41b277 
>   dev-support/ranger-docker/Dockerfile.ranger-knox bc78af9cc 
>   dev-support/ranger-docker/Dockerfile.ranger-tagsync 28dadd424 
>   dev-support/ranger-docker/Dockerfile.ranger-usersync ba7859ede 
>   dev-support/ranger-docker/README.md 248ab1fc9 
> 
> 
> Diff: https://reviews.apache.org/r/73999/diff/2/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Abhishek  Kumar
> 
>


Re: Review Request 73999: RANGER:3777 Execute permissions required in init scripts to run containers

Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73999/
-----------------------------------------------------------

(Updated May 25, 2022, 3:02 a.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3777
    https://issues.apache.org/jira/browse/RANGER-3777


Repository: ranger


Description
-------

The init scripts inside dev-support/ranger-docker/scripts do not have execute permissions for owner. 
Currently ranger and dependent services containers are failing due to absense of required permissions.


The patch also brings in changes from RANGER-3738 to ranger-2.3.


Diffs (updated)
-----

  dev-support/ranger-docker/Dockerfile.ranger b11e72666 
  dev-support/ranger-docker/Dockerfile.ranger-hadoop f25bc0d8d 
  dev-support/ranger-docker/Dockerfile.ranger-hbase 5a2f056a9 
  dev-support/ranger-docker/Dockerfile.ranger-hive 31afe33d9 
  dev-support/ranger-docker/Dockerfile.ranger-kafka 83c41b277 
  dev-support/ranger-docker/Dockerfile.ranger-knox bc78af9cc 
  dev-support/ranger-docker/Dockerfile.ranger-tagsync 28dadd424 
  dev-support/ranger-docker/Dockerfile.ranger-usersync ba7859ede 
  dev-support/ranger-docker/README.md 248ab1fc9 


Diff: https://reviews.apache.org/r/73999/diff/2/

Changes: https://reviews.apache.org/r/73999/diff/1-2/


Testing
-------

Tested locally.


Thanks,

Abhishek  Kumar