You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "khmarbaise (via GitHub)" <gi...@apache.org> on 2023/08/25 13:38:27 UTC
[GitHub] [maven-mvnd] khmarbaise opened a new pull request, #882: Removed superfluous public for tests
khmarbaise opened a new pull request, #882:
URL: https://github.com/apache/maven-mvnd/pull/882
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] timtebeek commented on pull request #882: Removed superfluous public for tests
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #882:
URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1735047823
Chiming in to say that if this is something you'd want removed across the board we have a ready made recipe for that at https://docs.openrewrite.org/recipes/java/testing/cleanup/testsshouldnotbepublic
It gets things [_mostly right_](https://github.com/search?q=org%3Aopenrewrite+TestsShouldNotBePublic&type=issues), but should be able to run that against 91 repositories quite easily through https://app.moderne.io/recipes/org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Let me know if you'd want me to add that to the list! :) And would it need a Jira issue if I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed superfluous public for tests [maven-mvnd]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #882:
URL: https://github.com/apache/maven-mvnd/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] khmarbaise commented on pull request #882: Removed superfluous public for tests
Posted by "khmarbaise (via GitHub)" <gi...@apache.org>.
khmarbaise commented on PR #882:
URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1693429591
Are those windows build not stable? Looks like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] khmarbaise commented on pull request #882: Removed superfluous public for tests
Posted by "khmarbaise (via GitHub)" <gi...@apache.org>.
khmarbaise commented on PR #882:
URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1701497839
@gnodet ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org