You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2026/07/21 13:35:09 UTC

[PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

hiroyuki-sato opened a new pull request, #50577:
URL: https://github.com/apache/arrow/pull/50577

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * SC2045: Iterating over ls output is fragile. Use globs.
   * SC2086: Double quote to prevent globbing and word splitting.
   * SC2223: This default assignment may cause DoS due to globbing. Quote it.
   
   
   ```
   shellcheck ci/scripts/python_wheel_xlinux_build.sh
   
   In ci/scripts/python_wheel_xlinux_build.sh line 36:
       if [[ -f visible_symbols.log && `cat visible_symbols.log | wc -l` -eq 0 ]]; then
                                       ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
   
   Did you mean:
       if [[ -f visible_symbols.log && $(cat visible_symbols.log | wc -l) -eq 0 ]]; then
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 57:
   : ${ARROW_ACERO:=ON}
     ^----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 58:
   : ${ARROW_AZURE:=ON}
     ^----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 59:
   : ${ARROW_DATASET:=ON}
     ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 60:
   : ${ARROW_FLIGHT:=ON}
     ^-----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 61:
   : ${ARROW_GANDIVA:=OFF}
     ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 62:
   : ${ARROW_GCS:=ON}
     ^--------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 63:
   : ${ARROW_HDFS:=ON}
     ^---------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 64:
   : ${ARROW_MIMALLOC:=ON}
     ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 65:
   : ${ARROW_ORC:=ON}
     ^--------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 66:
   : ${ARROW_PARQUET:=ON}
     ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 67:
   : ${PARQUET_REQUIRE_ENCRYPTION:=ON}
     ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 68:
   : ${ARROW_SUBSTRAIT:=ON}
     ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 69:
   : ${ARROW_S3:=ON}
     ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 70:
   : ${ARROW_TENSORFLOW:=ON}
     ^---------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 71:
   : ${ARROW_USE_MOLD:=OFF}
     ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 72:
   : ${ARROW_WITH_BROTLI:=ON}
     ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 73:
   : ${ARROW_WITH_BZ2:=ON}
     ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 74:
   : ${ARROW_WITH_LZ4:=ON}
     ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 75:
   : ${ARROW_WITH_OPENTELEMETRY:=ON}
     ^-----------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 76:
   : ${ARROW_WITH_SNAPPY:=ON}
     ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 77:
   : ${ARROW_WITH_ZLIB:=ON}
     ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 78:
   : ${ARROW_WITH_ZSTD:=ON}
     ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 79:
   : ${CMAKE_BUILD_TYPE:=release}
     ^--------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 80:
   : ${CMAKE_UNITY_BUILD:=ON}
     ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 81:
   : ${CMAKE_GENERATOR:=Ninja}
     ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 82:
   : ${VCPKG_ROOT:=/opt/vcpkg}
     ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 83:
   : ${VCPKG_FEATURE_FLAGS:=-manifests}
     ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 84:
   : ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
     ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 91:
       : ${ARROW_JEMALLOC:=OFF}
         ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 93:
       : ${ARROW_JEMALLOC:=ON}
         ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 97:
       : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
         ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 99:
       : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
         ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 106:
       -DARROW_ACERO=${ARROW_ACERO} \
                     ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_ACERO="${ARROW_ACERO}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 107:
       -DARROW_AZURE=${ARROW_AZURE} \
                     ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_AZURE="${ARROW_AZURE}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 113:
       -DARROW_DATASET=${ARROW_DATASET} \
                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_DATASET="${ARROW_DATASET}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 117:
       -DARROW_FLIGHT=${ARROW_FLIGHT} \
                      ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_FLIGHT="${ARROW_FLIGHT}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 118:
       -DARROW_GANDIVA=${ARROW_GANDIVA} \
                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_GANDIVA="${ARROW_GANDIVA}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 119:
       -DARROW_GCS=${ARROW_GCS} \
                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_GCS="${ARROW_GCS}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 120:
       -DARROW_HDFS=${ARROW_HDFS} \
                    ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_HDFS="${ARROW_HDFS}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 121:
       -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
                        ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 123:
       -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
                        ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 124:
       -DARROW_ORC=${ARROW_ORC} \
                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_ORC="${ARROW_ORC}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 126:
       -DARROW_PARQUET=${ARROW_PARQUET} \
                       ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_PARQUET="${ARROW_PARQUET}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 128:
       -DARROW_S3=${ARROW_S3} \
                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_S3="${ARROW_S3}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 129:
       -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
                         ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 130:
       -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
                          ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 132:
       -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
                        ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 133:
       -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
                           ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 134:
       -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
                        ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 135:
       -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
                        ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 136:
       -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
                                  ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 137:
       -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
                           ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 138:
       -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
                         ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 139:
       -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
                         ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 140:
       -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
                          ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 143:
       -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
                                            ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 144:
       -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
                           ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 145:
       -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
                                    ^---------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 147:
       -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
                              ^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 149:
       ${ARROW_EXTRA_CMAKE_FLAGS} \
       ^------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       "${ARROW_EXTRA_CMAKE_FLAGS}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 150:
       -G ${CMAKE_GENERATOR} \
          ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -G "${CMAKE_GENERATOR}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 181:
       -C cmake.build-type=${CMAKE_BUILD_TYPE:-Debug} \
                           ^------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       -C cmake.build-type="${CMAKE_BUILD_TYPE:-Debug}" \
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 191:
   unzip $wheel_name
         ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
   unzip "$wheel_name"
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 192:
   rm $wheel_name
      ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
   rm "$wheel_name"
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 193:
   for filename in $(ls pyarrow/*.so pyarrow/*.so.*); do
                   ^-- SC2045 (error): Iterating over ls output is fragile. Use globs.
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 195:
       strip --strip-debug $filename
                           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
       strip --strip-debug "$filename"
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 198:
   zip -r $wheel_name .
          ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
   zip -r "$wheel_name" .
   
   
   In ci/scripts/python_wheel_xlinux_build.sh line 199:
   mv $wheel_name ..
      ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean:
   mv "$wheel_name" ..
   
   For more information:
     https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi...
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
     https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
   ``` 
   
   ### What changes are included in this PR?
   
   * SC2045: Replace `ls` iteration with globs
   * SC2086: Quote variable expansions
   * SC2223: Quote default assignment
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #50577:
URL: https://github.com/apache/arrow/pull/50577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5036328790

   @github-actions crossbow submit python-wheel-manylinux-2-28* python-wheel-musllinux-1-2*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5034712111

   :warning: GitHub issue #50575 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5040434213

   @raulcd Thank you for your help!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5040667157

   @github-actions crossbow submit wheel-manylinux-2-28* wheel-musllinux-1-2*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5036339310

   ```
   Unable to match any tasks for `python-wheel-manylinux-2-28*`
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/29847495106
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3626571129


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -54,100 +54,100 @@ rm -rf /arrow/python/pyarrow/*.so
 rm -rf /arrow/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
-: ${ARROW_ACERO:=ON}
-: ${ARROW_AZURE:=ON}
-: ${ARROW_DATASET:=ON}
-: ${ARROW_FLIGHT:=ON}
-: ${ARROW_GANDIVA:=OFF}
-: ${ARROW_GCS:=ON}
-: ${ARROW_HDFS:=ON}
-: ${ARROW_MIMALLOC:=ON}
-: ${ARROW_ORC:=ON}
-: ${ARROW_PARQUET:=ON}
-: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
-: ${ARROW_SUBSTRAIT:=ON}
-: ${ARROW_S3:=ON}
-: ${ARROW_TENSORFLOW:=ON}
-: ${ARROW_USE_MOLD:=OFF}
-: ${ARROW_WITH_BROTLI:=ON}
-: ${ARROW_WITH_BZ2:=ON}
-: ${ARROW_WITH_LZ4:=ON}
-: ${ARROW_WITH_OPENTELEMETRY:=ON}
-: ${ARROW_WITH_SNAPPY:=ON}
-: ${ARROW_WITH_ZLIB:=ON}
-: ${ARROW_WITH_ZSTD:=ON}
-: ${CMAKE_BUILD_TYPE:=release}
-: ${CMAKE_UNITY_BUILD:=ON}
-: ${CMAKE_GENERATOR:=Ninja}
-: ${VCPKG_ROOT:=/opt/vcpkg}
-: ${VCPKG_FEATURE_FLAGS:=-manifests}
-: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
+: "${ARROW_ACERO:=ON}"
+: "${ARROW_AZURE:=ON}"
+: "${ARROW_DATASET:=ON}"
+: "${ARROW_FLIGHT:=ON}"
+: "${ARROW_GANDIVA:=OFF}"
+: "${ARROW_GCS:=ON}"
+: "${ARROW_HDFS:=ON}"
+: "${ARROW_MIMALLOC:=ON}"
+: "${ARROW_ORC:=ON}"
+: "${ARROW_PARQUET:=ON}"
+: "${PARQUET_REQUIRE_ENCRYPTION:=ON}"
+: "${ARROW_SUBSTRAIT:=ON}"
+: "${ARROW_S3:=ON}"
+: "${ARROW_TENSORFLOW:=ON}"
+: "${ARROW_USE_MOLD:=OFF}"
+: "${ARROW_WITH_BROTLI:=ON}"
+: "${ARROW_WITH_BZ2:=ON}"
+: "${ARROW_WITH_LZ4:=ON}"
+: "${ARROW_WITH_OPENTELEMETRY:=ON}"
+: "${ARROW_WITH_SNAPPY:=ON}"
+: "${ARROW_WITH_ZLIB:=ON}"
+: "${ARROW_WITH_ZSTD:=ON}"
+: "${CMAKE_BUILD_TYPE:=release}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${CMAKE_GENERATOR:=Ninja}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"
+: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
 
 if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
     # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
     # 4k and 64k page arm64 systems. For more context see
     # https://github.com/apache/arrow/issues/10929
     export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
-    : ${ARROW_JEMALLOC:=OFF}
+    : "${ARROW_JEMALLOC:=OFF}"
 else
-    : ${ARROW_JEMALLOC:=ON}
+    : "${ARROW_JEMALLOC:=ON}"
 fi
 
 if [[ "${LINUX_WHEEL_KIND:-}" == "musllinux" ]]; then
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}"
 else
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}"
 fi
 
 mkdir /tmp/arrow-build
 pushd /tmp/arrow-build
 
 cmake \
-    -DARROW_ACERO=${ARROW_ACERO} \
-    -DARROW_AZURE=${ARROW_AZURE} \
+    -DARROW_ACERO="${ARROW_ACERO}" \
+    -DARROW_AZURE="${ARROW_AZURE}" \
     -DARROW_BUILD_SHARED=ON \
     -DARROW_BUILD_STATIC=OFF \
     -DARROW_BUILD_TESTS=OFF \
     -DARROW_COMPUTE=ON \
     -DARROW_CSV=ON \
-    -DARROW_DATASET=${ARROW_DATASET} \
+    -DARROW_DATASET="${ARROW_DATASET}" \
     -DARROW_DEPENDENCY_SOURCE="VCPKG" \
     -DARROW_DEPENDENCY_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
-    -DARROW_FLIGHT=${ARROW_FLIGHT} \
-    -DARROW_GANDIVA=${ARROW_GANDIVA} \
-    -DARROW_GCS=${ARROW_GCS} \
-    -DARROW_HDFS=${ARROW_HDFS} \
-    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
+    -DARROW_FLIGHT="${ARROW_FLIGHT}" \
+    -DARROW_GANDIVA="${ARROW_GANDIVA}" \
+    -DARROW_GCS="${ARROW_GCS}" \
+    -DARROW_HDFS="${ARROW_HDFS}" \
+    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
     -DARROW_JSON=ON \
-    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
-    -DARROW_ORC=${ARROW_ORC} \
+    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
+    -DARROW_ORC="${ARROW_ORC}" \
     -DARROW_PACKAGE_KIND="python-wheel-${LINUX_WHEEL_KIND}${LINUX_WHEEL_VERSION}" \
-    -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DARROW_PARQUET="${ARROW_PARQUET}" \
     -DARROW_RPATH_ORIGIN=ON \
-    -DARROW_S3=${ARROW_S3} \
-    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
-    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
+    -DARROW_S3="${ARROW_S3}" \
+    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
+    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
     -DARROW_USE_CCACHE=ON \
-    -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
-    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
-    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
-    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
-    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
-    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
-    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
-    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
-    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
+    -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
+    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
+    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
+    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
+    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
+    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
+    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
+    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
+    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
     -DCMAKE_INSTALL_LIBDIR=lib \
     -DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
-    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
+    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
+    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
     -DVCPKG_MANIFEST_MODE=OFF \
-    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
+    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
     -Dxsimd_SOURCE=BUNDLED \
-    ${ARROW_EXTRA_CMAKE_FLAGS} \
-    -G ${CMAKE_GENERATOR} \
+    "${ARROW_EXTRA_CMAKE_FLAGS}" \

Review Comment:
   @kou Thank you for your comment. What do you think this change?
   
   ```diff
   +ARROW_EXTRA_CMAKE_FLAGS_ARRAY=()
    if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
        # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
        # 4k and 64k page arm64 systems. For more context see
        # https://github.com/apache/arrow/issues/10929
   -    export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
   +    ARROW_EXTRA_CMAKE_FLAGS_ARRAY+=("-DARROW_JEMALLOC_LG_PAGE=16")
        : "${ARROW_JEMALLOC:=OFF}"
    else
        : "${ARROW_JEMALLOC:=ON}"
   @@ -146,7 +148,7 @@ cmake \
        -DVCPKG_MANIFEST_MODE=OFF \
        -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
        -Dxsimd_SOURCE=BUNDLED \
   -    "${ARROW_EXTRA_CMAKE_FLAGS}" \
   +    "${ARROW_EXTRA_CMAKE_FLAGS_ARRAY[@]}" \
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3626710107


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -54,100 +54,100 @@ rm -rf /arrow/python/pyarrow/*.so
 rm -rf /arrow/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
-: ${ARROW_ACERO:=ON}
-: ${ARROW_AZURE:=ON}
-: ${ARROW_DATASET:=ON}
-: ${ARROW_FLIGHT:=ON}
-: ${ARROW_GANDIVA:=OFF}
-: ${ARROW_GCS:=ON}
-: ${ARROW_HDFS:=ON}
-: ${ARROW_MIMALLOC:=ON}
-: ${ARROW_ORC:=ON}
-: ${ARROW_PARQUET:=ON}
-: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
-: ${ARROW_SUBSTRAIT:=ON}
-: ${ARROW_S3:=ON}
-: ${ARROW_TENSORFLOW:=ON}
-: ${ARROW_USE_MOLD:=OFF}
-: ${ARROW_WITH_BROTLI:=ON}
-: ${ARROW_WITH_BZ2:=ON}
-: ${ARROW_WITH_LZ4:=ON}
-: ${ARROW_WITH_OPENTELEMETRY:=ON}
-: ${ARROW_WITH_SNAPPY:=ON}
-: ${ARROW_WITH_ZLIB:=ON}
-: ${ARROW_WITH_ZSTD:=ON}
-: ${CMAKE_BUILD_TYPE:=release}
-: ${CMAKE_UNITY_BUILD:=ON}
-: ${CMAKE_GENERATOR:=Ninja}
-: ${VCPKG_ROOT:=/opt/vcpkg}
-: ${VCPKG_FEATURE_FLAGS:=-manifests}
-: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
+: "${ARROW_ACERO:=ON}"
+: "${ARROW_AZURE:=ON}"
+: "${ARROW_DATASET:=ON}"
+: "${ARROW_FLIGHT:=ON}"
+: "${ARROW_GANDIVA:=OFF}"
+: "${ARROW_GCS:=ON}"
+: "${ARROW_HDFS:=ON}"
+: "${ARROW_MIMALLOC:=ON}"
+: "${ARROW_ORC:=ON}"
+: "${ARROW_PARQUET:=ON}"
+: "${PARQUET_REQUIRE_ENCRYPTION:=ON}"
+: "${ARROW_SUBSTRAIT:=ON}"
+: "${ARROW_S3:=ON}"
+: "${ARROW_TENSORFLOW:=ON}"
+: "${ARROW_USE_MOLD:=OFF}"
+: "${ARROW_WITH_BROTLI:=ON}"
+: "${ARROW_WITH_BZ2:=ON}"
+: "${ARROW_WITH_LZ4:=ON}"
+: "${ARROW_WITH_OPENTELEMETRY:=ON}"
+: "${ARROW_WITH_SNAPPY:=ON}"
+: "${ARROW_WITH_ZLIB:=ON}"
+: "${ARROW_WITH_ZSTD:=ON}"
+: "${CMAKE_BUILD_TYPE:=release}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${CMAKE_GENERATOR:=Ninja}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"
+: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
 
 if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
     # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
     # 4k and 64k page arm64 systems. For more context see
     # https://github.com/apache/arrow/issues/10929
     export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
-    : ${ARROW_JEMALLOC:=OFF}
+    : "${ARROW_JEMALLOC:=OFF}"
 else
-    : ${ARROW_JEMALLOC:=ON}
+    : "${ARROW_JEMALLOC:=ON}"
 fi
 
 if [[ "${LINUX_WHEEL_KIND:-}" == "musllinux" ]]; then
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}"
 else
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}"
 fi
 
 mkdir /tmp/arrow-build
 pushd /tmp/arrow-build
 
 cmake \
-    -DARROW_ACERO=${ARROW_ACERO} \
-    -DARROW_AZURE=${ARROW_AZURE} \
+    -DARROW_ACERO="${ARROW_ACERO}" \
+    -DARROW_AZURE="${ARROW_AZURE}" \
     -DARROW_BUILD_SHARED=ON \
     -DARROW_BUILD_STATIC=OFF \
     -DARROW_BUILD_TESTS=OFF \
     -DARROW_COMPUTE=ON \
     -DARROW_CSV=ON \
-    -DARROW_DATASET=${ARROW_DATASET} \
+    -DARROW_DATASET="${ARROW_DATASET}" \
     -DARROW_DEPENDENCY_SOURCE="VCPKG" \
     -DARROW_DEPENDENCY_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
-    -DARROW_FLIGHT=${ARROW_FLIGHT} \
-    -DARROW_GANDIVA=${ARROW_GANDIVA} \
-    -DARROW_GCS=${ARROW_GCS} \
-    -DARROW_HDFS=${ARROW_HDFS} \
-    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
+    -DARROW_FLIGHT="${ARROW_FLIGHT}" \
+    -DARROW_GANDIVA="${ARROW_GANDIVA}" \
+    -DARROW_GCS="${ARROW_GCS}" \
+    -DARROW_HDFS="${ARROW_HDFS}" \
+    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
     -DARROW_JSON=ON \
-    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
-    -DARROW_ORC=${ARROW_ORC} \
+    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
+    -DARROW_ORC="${ARROW_ORC}" \
     -DARROW_PACKAGE_KIND="python-wheel-${LINUX_WHEEL_KIND}${LINUX_WHEEL_VERSION}" \
-    -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DARROW_PARQUET="${ARROW_PARQUET}" \
     -DARROW_RPATH_ORIGIN=ON \
-    -DARROW_S3=${ARROW_S3} \
-    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
-    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
+    -DARROW_S3="${ARROW_S3}" \
+    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
+    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
     -DARROW_USE_CCACHE=ON \
-    -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
-    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
-    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
-    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
-    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
-    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
-    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
-    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
-    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
+    -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
+    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
+    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
+    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
+    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
+    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
+    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
+    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
+    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
     -DCMAKE_INSTALL_LIBDIR=lib \
     -DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
-    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
+    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
+    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
     -DVCPKG_MANIFEST_MODE=OFF \
-    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
+    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
     -Dxsimd_SOURCE=BUNDLED \
-    ${ARROW_EXTRA_CMAKE_FLAGS} \
-    -G ${CMAKE_GENERATOR} \
+    "${ARROW_EXTRA_CMAKE_FLAGS}" \

Review Comment:
   Thanks. removed `_ARRAY` suffix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5064845321

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7667f41324f4df79353019bbd323832ce67d6390.
   
   There was 1 benchmark result indicating a performance regression:
   
   - Commit Run on `test-mac-arm` at [2026-07-23 23:44:53Z](https://conbench.arrow-dev.org/compare/runs/067063c0216f4668b95abb58aa8c1271...162e1f03205e4bd5aa2147490b1adf88/)
     - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-11, scale_factor=1](https://conbench.arrow-dev.org/compare/benchmarks/06a6284d5db37ac1800001c3168c9763...06a62a86b0af727f80008cd8d3df049c)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/89367826734) has more details. It also includes information about 208 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5040683495

   Revision: be946444d2827f1c6c6864d028770249dc16b1b4
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-f639e5d2da](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f639e5d2da)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142975/job/88805083690)|
   |wheel-manylinux-2-28-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144114/job/88805087364)|
   |wheel-manylinux-2-28-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142858/job/88805083138)|
   |wheel-manylinux-2-28-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144029/job/88805087096)|
   |wheel-manylinux-2-28-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144296/job/88805087913)|
   |wheel-manylinux-2-28-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144365/job/88805088126)|
   |wheel-manylinux-2-28-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144188/job/88805087718)|
   |wheel-manylinux-2-28-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143120/job/88805084097)|
   |wheel-manylinux-2-28-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143399/job/88805084912)|
   |wheel-manylinux-2-28-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-manylinux-2-28-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142956/job/88805083639)|
   |wheel-musllinux-1-2-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143633/job/88805086026)|
   |wheel-musllinux-1-2-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142983/job/88805083624)|
   |wheel-musllinux-1-2-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143693/job/88805086062)|
   |wheel-musllinux-1-2-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143791/job/88805086281)|
   |wheel-musllinux-1-2-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142724/job/88805082816)|
   |wheel-musllinux-1-2-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143404/job/88805084979)|
   |wheel-musllinux-1-2-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143721/job/88805085968)|
   |wheel-musllinux-1-2-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882144313/job/88805088062)|
   |wheel-musllinux-1-2-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29882142612/job/88805082530)|
   |wheel-musllinux-1-2-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f639e5d2da-github-wheel-musllinux-1-2-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29882143460/job/88805085203)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5040435432

   @github-actions crossbow submit wheel-manylinux-2-28* wheel-musllinux-1-2*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5043872194

   The failures are unrelated, they are also failing on main for the nightly builds, it is tracked here:
   - https://github.com/apache/arrow/issues/50579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5036347065

   @github-actions crossbow submit wheel-manylinux-2-28* wheel-musllinux-1-2*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3625647472


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -54,100 +54,100 @@ rm -rf /arrow/python/pyarrow/*.so
 rm -rf /arrow/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
-: ${ARROW_ACERO:=ON}
-: ${ARROW_AZURE:=ON}
-: ${ARROW_DATASET:=ON}
-: ${ARROW_FLIGHT:=ON}
-: ${ARROW_GANDIVA:=OFF}
-: ${ARROW_GCS:=ON}
-: ${ARROW_HDFS:=ON}
-: ${ARROW_MIMALLOC:=ON}
-: ${ARROW_ORC:=ON}
-: ${ARROW_PARQUET:=ON}
-: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
-: ${ARROW_SUBSTRAIT:=ON}
-: ${ARROW_S3:=ON}
-: ${ARROW_TENSORFLOW:=ON}
-: ${ARROW_USE_MOLD:=OFF}
-: ${ARROW_WITH_BROTLI:=ON}
-: ${ARROW_WITH_BZ2:=ON}
-: ${ARROW_WITH_LZ4:=ON}
-: ${ARROW_WITH_OPENTELEMETRY:=ON}
-: ${ARROW_WITH_SNAPPY:=ON}
-: ${ARROW_WITH_ZLIB:=ON}
-: ${ARROW_WITH_ZSTD:=ON}
-: ${CMAKE_BUILD_TYPE:=release}
-: ${CMAKE_UNITY_BUILD:=ON}
-: ${CMAKE_GENERATOR:=Ninja}
-: ${VCPKG_ROOT:=/opt/vcpkg}
-: ${VCPKG_FEATURE_FLAGS:=-manifests}
-: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
+: "${ARROW_ACERO:=ON}"
+: "${ARROW_AZURE:=ON}"
+: "${ARROW_DATASET:=ON}"
+: "${ARROW_FLIGHT:=ON}"
+: "${ARROW_GANDIVA:=OFF}"
+: "${ARROW_GCS:=ON}"
+: "${ARROW_HDFS:=ON}"
+: "${ARROW_MIMALLOC:=ON}"
+: "${ARROW_ORC:=ON}"
+: "${ARROW_PARQUET:=ON}"
+: "${PARQUET_REQUIRE_ENCRYPTION:=ON}"
+: "${ARROW_SUBSTRAIT:=ON}"
+: "${ARROW_S3:=ON}"
+: "${ARROW_TENSORFLOW:=ON}"
+: "${ARROW_USE_MOLD:=OFF}"
+: "${ARROW_WITH_BROTLI:=ON}"
+: "${ARROW_WITH_BZ2:=ON}"
+: "${ARROW_WITH_LZ4:=ON}"
+: "${ARROW_WITH_OPENTELEMETRY:=ON}"
+: "${ARROW_WITH_SNAPPY:=ON}"
+: "${ARROW_WITH_ZLIB:=ON}"
+: "${ARROW_WITH_ZSTD:=ON}"
+: "${CMAKE_BUILD_TYPE:=release}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${CMAKE_GENERATOR:=Ninja}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"
+: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
 
 if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
     # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
     # 4k and 64k page arm64 systems. For more context see
     # https://github.com/apache/arrow/issues/10929
     export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
-    : ${ARROW_JEMALLOC:=OFF}
+    : "${ARROW_JEMALLOC:=OFF}"
 else
-    : ${ARROW_JEMALLOC:=ON}
+    : "${ARROW_JEMALLOC:=ON}"
 fi
 
 if [[ "${LINUX_WHEEL_KIND:-}" == "musllinux" ]]; then
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}"
 else
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}"
 fi
 
 mkdir /tmp/arrow-build
 pushd /tmp/arrow-build
 
 cmake \
-    -DARROW_ACERO=${ARROW_ACERO} \
-    -DARROW_AZURE=${ARROW_AZURE} \
+    -DARROW_ACERO="${ARROW_ACERO}" \
+    -DARROW_AZURE="${ARROW_AZURE}" \
     -DARROW_BUILD_SHARED=ON \
     -DARROW_BUILD_STATIC=OFF \
     -DARROW_BUILD_TESTS=OFF \
     -DARROW_COMPUTE=ON \
     -DARROW_CSV=ON \
-    -DARROW_DATASET=${ARROW_DATASET} \
+    -DARROW_DATASET="${ARROW_DATASET}" \
     -DARROW_DEPENDENCY_SOURCE="VCPKG" \
     -DARROW_DEPENDENCY_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
-    -DARROW_FLIGHT=${ARROW_FLIGHT} \
-    -DARROW_GANDIVA=${ARROW_GANDIVA} \
-    -DARROW_GCS=${ARROW_GCS} \
-    -DARROW_HDFS=${ARROW_HDFS} \
-    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
+    -DARROW_FLIGHT="${ARROW_FLIGHT}" \
+    -DARROW_GANDIVA="${ARROW_GANDIVA}" \
+    -DARROW_GCS="${ARROW_GCS}" \
+    -DARROW_HDFS="${ARROW_HDFS}" \
+    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
     -DARROW_JSON=ON \
-    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
-    -DARROW_ORC=${ARROW_ORC} \
+    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
+    -DARROW_ORC="${ARROW_ORC}" \
     -DARROW_PACKAGE_KIND="python-wheel-${LINUX_WHEEL_KIND}${LINUX_WHEEL_VERSION}" \
-    -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DARROW_PARQUET="${ARROW_PARQUET}" \
     -DARROW_RPATH_ORIGIN=ON \
-    -DARROW_S3=${ARROW_S3} \
-    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
-    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
+    -DARROW_S3="${ARROW_S3}" \
+    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
+    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
     -DARROW_USE_CCACHE=ON \
-    -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
-    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
-    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
-    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
-    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
-    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
-    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
-    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
-    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
+    -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
+    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
+    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
+    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
+    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
+    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
+    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
+    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
+    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
     -DCMAKE_INSTALL_LIBDIR=lib \
     -DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
-    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
+    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
+    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
     -DVCPKG_MANIFEST_MODE=OFF \
-    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
+    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
     -Dxsimd_SOURCE=BUNDLED \
-    ${ARROW_EXTRA_CMAKE_FLAGS} \
-    -G ${CMAKE_GENERATOR} \
+    "${ARROW_EXTRA_CMAKE_FLAGS}" \

Review Comment:
   Could you keep accepting multiple flags?
   We may use multiple flags later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3628923958


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -33,7 +33,8 @@ function check_arrow_visibility {
     fi
     grep ' T ' nm_arrow.log | grep -v -E "${allowed_symbols}" | cat - > visible_symbols.log
 
-    if [[ -f visible_symbols.log && `cat visible_symbols.log | wc -l` -eq 0 ]]; then
+    # Return early if the log file exists but is empty.
+    if [[ -f visible_symbols.log && ! -s visible_symbols.log ]]; then

Review Comment:
   I've just learnt about the `-f` && `! -s` combo, nice!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5040453931

   Revision: 8336ea1ac94b1bd7df1ce4a8537c41aadc8f1c4f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-efd09d92b1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-efd09d92b1)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168411/job/88799052273)|
   |wheel-manylinux-2-28-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168284/job/88799051931)|
   |wheel-manylinux-2-28-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167934/job/88799051028)|
   |wheel-manylinux-2-28-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167915/job/88799051030)|
   |wheel-manylinux-2-28-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167738/job/88799050372)|
   |wheel-manylinux-2-28-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880169032/job/88799054375)|
   |wheel-manylinux-2-28-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168879/job/88799053902)|
   |wheel-manylinux-2-28-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168860/job/88799053570)|
   |wheel-manylinux-2-28-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167816/job/88799050675)|
   |wheel-manylinux-2-28-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-manylinux-2-28-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168794/job/88799053664)|
   |wheel-musllinux-1-2-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168293/job/88799051929)|
   |wheel-musllinux-1-2-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880169121/job/88799054612)|
   |wheel-musllinux-1-2-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168960/job/88799054109)|
   |wheel-musllinux-1-2-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167611/job/88799050059)|
   |wheel-musllinux-1-2-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167382/job/88799049605)|
   |wheel-musllinux-1-2-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167390/job/88799049515)|
   |wheel-musllinux-1-2-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880168490/job/88799052697)|
   |wheel-musllinux-1-2-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880169122/job/88799054659)|
   |wheel-musllinux-1-2-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167556/job/88799049878)|
   |wheel-musllinux-1-2-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-efd09d92b1-github-wheel-musllinux-1-2-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29880167860/job/88799052961)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5042697216

    I’m not sure why two tests are still failing. 
   * wheel-manylinux-2-28-cp312-cp312-arm64
   * wheel-manylinux-2-28-cp312-cp312-amd64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3622620914


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -54,100 +54,100 @@ rm -rf /arrow/python/pyarrow/*.so
 rm -rf /arrow/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
-: ${ARROW_ACERO:=ON}
-: ${ARROW_AZURE:=ON}
-: ${ARROW_DATASET:=ON}
-: ${ARROW_FLIGHT:=ON}
-: ${ARROW_GANDIVA:=OFF}
-: ${ARROW_GCS:=ON}
-: ${ARROW_HDFS:=ON}
-: ${ARROW_MIMALLOC:=ON}
-: ${ARROW_ORC:=ON}
-: ${ARROW_PARQUET:=ON}
-: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
-: ${ARROW_SUBSTRAIT:=ON}
-: ${ARROW_S3:=ON}
-: ${ARROW_TENSORFLOW:=ON}
-: ${ARROW_USE_MOLD:=OFF}
-: ${ARROW_WITH_BROTLI:=ON}
-: ${ARROW_WITH_BZ2:=ON}
-: ${ARROW_WITH_LZ4:=ON}
-: ${ARROW_WITH_OPENTELEMETRY:=ON}
-: ${ARROW_WITH_SNAPPY:=ON}
-: ${ARROW_WITH_ZLIB:=ON}
-: ${ARROW_WITH_ZSTD:=ON}
-: ${CMAKE_BUILD_TYPE:=release}
-: ${CMAKE_UNITY_BUILD:=ON}
-: ${CMAKE_GENERATOR:=Ninja}
-: ${VCPKG_ROOT:=/opt/vcpkg}
-: ${VCPKG_FEATURE_FLAGS:=-manifests}
-: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
+: "${ARROW_ACERO:=ON}"
+: "${ARROW_AZURE:=ON}"
+: "${ARROW_DATASET:=ON}"
+: "${ARROW_FLIGHT:=ON}"
+: "${ARROW_GANDIVA:=OFF}"
+: "${ARROW_GCS:=ON}"
+: "${ARROW_HDFS:=ON}"
+: "${ARROW_MIMALLOC:=ON}"
+: "${ARROW_ORC:=ON}"
+: "${ARROW_PARQUET:=ON}"
+: "${PARQUET_REQUIRE_ENCRYPTION:=ON}"
+: "${ARROW_SUBSTRAIT:=ON}"
+: "${ARROW_S3:=ON}"
+: "${ARROW_TENSORFLOW:=ON}"
+: "${ARROW_USE_MOLD:=OFF}"
+: "${ARROW_WITH_BROTLI:=ON}"
+: "${ARROW_WITH_BZ2:=ON}"
+: "${ARROW_WITH_LZ4:=ON}"
+: "${ARROW_WITH_OPENTELEMETRY:=ON}"
+: "${ARROW_WITH_SNAPPY:=ON}"
+: "${ARROW_WITH_ZLIB:=ON}"
+: "${ARROW_WITH_ZSTD:=ON}"
+: "${CMAKE_BUILD_TYPE:=release}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${CMAKE_GENERATOR:=Ninja}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"
+: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
 
 if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
     # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
     # 4k and 64k page arm64 systems. For more context see
     # https://github.com/apache/arrow/issues/10929
     export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
-    : ${ARROW_JEMALLOC:=OFF}
+    : "${ARROW_JEMALLOC:=OFF}"
 else
-    : ${ARROW_JEMALLOC:=ON}
+    : "${ARROW_JEMALLOC:=ON}"
 fi
 
 if [[ "${LINUX_WHEEL_KIND:-}" == "musllinux" ]]; then
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}"
 else
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}"
 fi
 
 mkdir /tmp/arrow-build
 pushd /tmp/arrow-build
 
 cmake \
-    -DARROW_ACERO=${ARROW_ACERO} \
-    -DARROW_AZURE=${ARROW_AZURE} \
+    -DARROW_ACERO="${ARROW_ACERO}" \
+    -DARROW_AZURE="${ARROW_AZURE}" \
     -DARROW_BUILD_SHARED=ON \
     -DARROW_BUILD_STATIC=OFF \
     -DARROW_BUILD_TESTS=OFF \
     -DARROW_COMPUTE=ON \
     -DARROW_CSV=ON \
-    -DARROW_DATASET=${ARROW_DATASET} \
+    -DARROW_DATASET="${ARROW_DATASET}" \
     -DARROW_DEPENDENCY_SOURCE="VCPKG" \
     -DARROW_DEPENDENCY_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
-    -DARROW_FLIGHT=${ARROW_FLIGHT} \
-    -DARROW_GANDIVA=${ARROW_GANDIVA} \
-    -DARROW_GCS=${ARROW_GCS} \
-    -DARROW_HDFS=${ARROW_HDFS} \
-    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
+    -DARROW_FLIGHT="${ARROW_FLIGHT}" \
+    -DARROW_GANDIVA="${ARROW_GANDIVA}" \
+    -DARROW_GCS="${ARROW_GCS}" \
+    -DARROW_HDFS="${ARROW_HDFS}" \
+    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
     -DARROW_JSON=ON \
-    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
-    -DARROW_ORC=${ARROW_ORC} \
+    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
+    -DARROW_ORC="${ARROW_ORC}" \
     -DARROW_PACKAGE_KIND="python-wheel-${LINUX_WHEEL_KIND}${LINUX_WHEEL_VERSION}" \
-    -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DARROW_PARQUET="${ARROW_PARQUET}" \
     -DARROW_RPATH_ORIGIN=ON \
-    -DARROW_S3=${ARROW_S3} \
-    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
-    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
+    -DARROW_S3="${ARROW_S3}" \
+    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
+    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
     -DARROW_USE_CCACHE=ON \
-    -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
-    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
-    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
-    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
-    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
-    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
-    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
-    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
-    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
+    -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
+    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
+    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
+    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
+    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
+    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
+    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
+    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
+    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
     -DCMAKE_INSTALL_LIBDIR=lib \
     -DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
-    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
+    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
+    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
     -DVCPKG_MANIFEST_MODE=OFF \
-    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
+    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
     -Dxsimd_SOURCE=BUNDLED \
-    ${ARROW_EXTRA_CMAKE_FLAGS} \
-    -G ${CMAKE_GENERATOR} \
+    "${ARROW_EXTRA_CMAKE_FLAGS}" \

Review Comment:
   `ARROW_EXTRA_CMAKE_FLAGS` defined here.
   The name `ARROW_EXTRA_CMAKE_FLAGS` looks plural, but it seems to hold just a single flag
   
   https://github.com/apache/arrow/pull/50577/changes#diff-b94a3d1c422d08ea66a49aaa0e824d0fc7ec43a3488900d929f7bee55d82a547R90
   
   ```bash
   if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
       # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
       # 4k and 64k page arm64 systems. For more context see
       # https://github.com/apache/arrow/issues/10929
       export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
       : ${ARROW_JEMALLOC:=OFF}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5034822952

   @github-actions crossbow submit python-wheel-manylinux-2-28 python-wheel-musllinux-1-2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5036378147

   Revision: 1a783573c455bf145bd6ecb6bc1bcc3aeb77e27a
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-9720cb735d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9720cb735d)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735105/job/88692515831)|
   |wheel-manylinux-2-28-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847734663/job/88692514211)|
   |wheel-manylinux-2-28-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735519/job/88692516717)|
   |wheel-manylinux-2-28-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847739117/job/88692529373)|
   |wheel-manylinux-2-28-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735187/job/88692515640)|
   |wheel-manylinux-2-28-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737506/job/88692524132)|
   |wheel-manylinux-2-28-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735989/job/88692518840)|
   |wheel-manylinux-2-28-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737168/job/88692522394)|
   |wheel-manylinux-2-28-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847734478/job/88692513208)|
   |wheel-manylinux-2-28-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-manylinux-2-28-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847738853/job/88692528819)|
   |wheel-musllinux-1-2-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847738630/job/88692527584)|
   |wheel-musllinux-1-2-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737204/job/88692522670)|
   |wheel-musllinux-1-2-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735962/job/88692518483)|
   |wheel-musllinux-1-2-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737576/job/88692524279)|
   |wheel-musllinux-1-2-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847736557/job/88692520814)|
   |wheel-musllinux-1-2-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847735768/job/88692517573)|
   |wheel-musllinux-1-2-cp314-cp314-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp314-cp314-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737265/job/88692522976)|
   |wheel-musllinux-1-2-cp314-cp314-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp314-cp314-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847734190/job/88692512372)|
   |wheel-musllinux-1-2-cp314-cp314t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp314-cp314t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/29847734407/job/88692513234)|
   |wheel-musllinux-1-2-cp314-cp314t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-9720cb735d-github-wheel-musllinux-1-2-cp314-cp314t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/29847737000/job/88692521849)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50577:
URL: https://github.com/apache/arrow/pull/50577#issuecomment-5034834154

   ```
   Unable to match any tasks for `python-wheel-manylinux-2-28`
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/29835970200
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50577:
URL: https://github.com/apache/arrow/pull/50577#discussion_r3626596165


##########
ci/scripts/python_wheel_xlinux_build.sh:
##########
@@ -54,100 +54,100 @@ rm -rf /arrow/python/pyarrow/*.so
 rm -rf /arrow/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
-: ${ARROW_ACERO:=ON}
-: ${ARROW_AZURE:=ON}
-: ${ARROW_DATASET:=ON}
-: ${ARROW_FLIGHT:=ON}
-: ${ARROW_GANDIVA:=OFF}
-: ${ARROW_GCS:=ON}
-: ${ARROW_HDFS:=ON}
-: ${ARROW_MIMALLOC:=ON}
-: ${ARROW_ORC:=ON}
-: ${ARROW_PARQUET:=ON}
-: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
-: ${ARROW_SUBSTRAIT:=ON}
-: ${ARROW_S3:=ON}
-: ${ARROW_TENSORFLOW:=ON}
-: ${ARROW_USE_MOLD:=OFF}
-: ${ARROW_WITH_BROTLI:=ON}
-: ${ARROW_WITH_BZ2:=ON}
-: ${ARROW_WITH_LZ4:=ON}
-: ${ARROW_WITH_OPENTELEMETRY:=ON}
-: ${ARROW_WITH_SNAPPY:=ON}
-: ${ARROW_WITH_ZLIB:=ON}
-: ${ARROW_WITH_ZSTD:=ON}
-: ${CMAKE_BUILD_TYPE:=release}
-: ${CMAKE_UNITY_BUILD:=ON}
-: ${CMAKE_GENERATOR:=Ninja}
-: ${VCPKG_ROOT:=/opt/vcpkg}
-: ${VCPKG_FEATURE_FLAGS:=-manifests}
-: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}
+: "${ARROW_ACERO:=ON}"
+: "${ARROW_AZURE:=ON}"
+: "${ARROW_DATASET:=ON}"
+: "${ARROW_FLIGHT:=ON}"
+: "${ARROW_GANDIVA:=OFF}"
+: "${ARROW_GCS:=ON}"
+: "${ARROW_HDFS:=ON}"
+: "${ARROW_MIMALLOC:=ON}"
+: "${ARROW_ORC:=ON}"
+: "${ARROW_PARQUET:=ON}"
+: "${PARQUET_REQUIRE_ENCRYPTION:=ON}"
+: "${ARROW_SUBSTRAIT:=ON}"
+: "${ARROW_S3:=ON}"
+: "${ARROW_TENSORFLOW:=ON}"
+: "${ARROW_USE_MOLD:=OFF}"
+: "${ARROW_WITH_BROTLI:=ON}"
+: "${ARROW_WITH_BZ2:=ON}"
+: "${ARROW_WITH_LZ4:=ON}"
+: "${ARROW_WITH_OPENTELEMETRY:=ON}"
+: "${ARROW_WITH_SNAPPY:=ON}"
+: "${ARROW_WITH_ZLIB:=ON}"
+: "${ARROW_WITH_ZSTD:=ON}"
+: "${CMAKE_BUILD_TYPE:=release}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${CMAKE_GENERATOR:=Ninja}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"
+: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
 
 if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
     # Build jemalloc --with-lg-page=16 in order to make the wheel work on both
     # 4k and 64k page arm64 systems. For more context see
     # https://github.com/apache/arrow/issues/10929
     export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
-    : ${ARROW_JEMALLOC:=OFF}
+    : "${ARROW_JEMALLOC:=OFF}"
 else
-    : ${ARROW_JEMALLOC:=ON}
+    : "${ARROW_JEMALLOC:=ON}"
 fi
 
 if [[ "${LINUX_WHEEL_KIND:-}" == "musllinux" ]]; then
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=OFF}"
 else
-    : ${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}
+    : "${CMAKE_INTERPROCEDURAL_OPTIMIZATION:=ON}"
 fi
 
 mkdir /tmp/arrow-build
 pushd /tmp/arrow-build
 
 cmake \
-    -DARROW_ACERO=${ARROW_ACERO} \
-    -DARROW_AZURE=${ARROW_AZURE} \
+    -DARROW_ACERO="${ARROW_ACERO}" \
+    -DARROW_AZURE="${ARROW_AZURE}" \
     -DARROW_BUILD_SHARED=ON \
     -DARROW_BUILD_STATIC=OFF \
     -DARROW_BUILD_TESTS=OFF \
     -DARROW_COMPUTE=ON \
     -DARROW_CSV=ON \
-    -DARROW_DATASET=${ARROW_DATASET} \
+    -DARROW_DATASET="${ARROW_DATASET}" \
     -DARROW_DEPENDENCY_SOURCE="VCPKG" \
     -DARROW_DEPENDENCY_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
-    -DARROW_FLIGHT=${ARROW_FLIGHT} \
-    -DARROW_GANDIVA=${ARROW_GANDIVA} \
-    -DARROW_GCS=${ARROW_GCS} \
-    -DARROW_HDFS=${ARROW_HDFS} \
-    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
+    -DARROW_FLIGHT="${ARROW_FLIGHT}" \
+    -DARROW_GANDIVA="${ARROW_GANDIVA}" \
+    -DARROW_GCS="${ARROW_GCS}" \
+    -DARROW_HDFS="${ARROW_HDFS}" \
+    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \
     -DARROW_JSON=ON \
-    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
-    -DARROW_ORC=${ARROW_ORC} \
+    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \
+    -DARROW_ORC="${ARROW_ORC}" \
     -DARROW_PACKAGE_KIND="python-wheel-${LINUX_WHEEL_KIND}${LINUX_WHEEL_VERSION}" \
-    -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DARROW_PARQUET="${ARROW_PARQUET}" \
     -DARROW_RPATH_ORIGIN=ON \
-    -DARROW_S3=${ARROW_S3} \
-    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
-    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
+    -DARROW_S3="${ARROW_S3}" \
+    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \
+    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \
     -DARROW_USE_CCACHE=ON \
-    -DARROW_USE_MOLD=${ARROW_USE_MOLD} \
-    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
-    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
-    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
-    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
-    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
-    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
-    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
-    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
+    -DARROW_USE_MOLD="${ARROW_USE_MOLD}" \
+    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \
+    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \
+    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \
+    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \
+    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \
+    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \
+    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \
+    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \
     -DCMAKE_INSTALL_LIBDIR=lib \
     -DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${CMAKE_INTERPROCEDURAL_OPTIMIZATION} \
-    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION}" \
+    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \
+    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \
     -DVCPKG_MANIFEST_MODE=OFF \
-    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
+    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
     -Dxsimd_SOURCE=BUNDLED \
-    ${ARROW_EXTRA_CMAKE_FLAGS} \
-    -G ${CMAKE_GENERATOR} \
+    "${ARROW_EXTRA_CMAKE_FLAGS}" \

Review Comment:
   We don't need `_ARRAY` suffix. It's redundant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org