You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 09:25:48 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
pnowojski commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375139240
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
Review comment:
nit: pass through constructor? Getting metric group from a variable named `toNotifyOnCheckpoint` looks a bit strange?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services