[GitHub] [flink] fapaul commented on a diff in pull request #19430: [BK-1.15][FLINK-26931][Connector/pulsar] Make the producer name and consumer name unique in Pulsar

[GitBox <gi...@apache.org>]

fapaul commented on code in PR #19430:
URL: https://github.com/apache/flink/pull/19430#discussion_r859938837


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarClientFactory.java:
##########
@@ -153,7 +153,7 @@ public static PulsarClient createClient(PulsarConfiguration configuration) {
 
     /**
      * PulsarAdmin shares almost the same configuration with PulsarClient, but we separate this
-     * create method for directly creating it.
+     * creating method for directly use it.

Review Comment:
   Nit: I am having a hard time understanding this doc string. Can you maybe rephrase it?



##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/config/PulsarSinkConfigUtils.java:
##########
@@ -70,7 +71,10 @@ public static <T> ProducerBuilder<T> createProducerBuilder(
             PulsarClient client, Schema<T> schema, SinkConfiguration configuration) {
         ProducerBuilder<T> builder = client.newProducer(schema);
 
-        configuration.useOption(PULSAR_PRODUCER_NAME, builder::producerName);
+        configuration.useOption(

Review Comment:
   What happens during an application restart? I guess a new producerName is generated. Is this a problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org