You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2018/06/07 15:21:11 UTC

[GitHub] spark pull request #21483: [SPARK-24477][SPARK-24454][ML][PYTHON] Imports su...

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21483#discussion_r193785229
  
    --- Diff: python/pyspark/ml/__init__.py ---
    @@ -21,5 +21,11 @@
     """
     from pyspark.ml.base import Estimator, Model, Transformer, UnaryTransformer
     from pyspark.ml.pipeline import Pipeline, PipelineModel
    +from pyspark.ml import classification, clustering, evaluation, feature, fpm, \
    +    image, pipeline, recommendation, regression, stat, tuning, util
     
    -__all__ = ["Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel"]
    +__all__ = [
    +    "Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel",
    +    "base", "classification", "clustering", "evaluation", "feature", "fpm",
    --- End diff --
    
    base shouldn't be imported by default


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org