You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/30 01:40:13 UTC

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13156: Support for middle manager less druid, tasks launch as k8s jobs

imply-cheddar commented on code in PR #13156:
URL: https://github.com/apache/druid/pull/13156#discussion_r984139254


##########
distribution/docker/peon.sh:
##########
@@ -0,0 +1,153 @@
+#!/bin/sh

Review Comment:
   Meta commentary: it would be cool (and I don't think too crazy) if there was a Cli target that is like "task" which essentially does a remote bootstrap.
   
   I.e. it could start up and the first thing it does is read some config for the overlord process, "phone home" to ask for the task spec and runtime properties, and then use those to bootstrap.  
   
   This might open up security holes, so it would probably have to be done with some sort of shared secret or something, maybe?  But anyway, might simplify this script into something that is relatively generic and not even k8s-dependent.
   
   Could also be done as an evolution of this change post-merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org