You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/17 20:22:47 UTC
Review Request 43667: Modified existing scheduler tests as an
aftermath of pipelining change.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570
Repository: mesos
Description
-------
This change modifies the existing tests to handle the new `connected/disconnected` semantics that were introduced as a result of the pipelining change.
Now `connected` is possible to invoked more then once i.e. during test shutdown, the master closed the event stream making us call the `disconnected` callback. However, the master detector can still detect the same master and establish a connection to it while it is shutting down leading to `connected` callback be invoked again in some cases.
Diffs
-----
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43667/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43667: Modified existing scheduler tests as an
aftermath of pipelining change.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/#review121049
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 10:46 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43667/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing tests to handle the new `connected/disconnected` semantics that were introduced as a result of the pipelining change.
>
> Now `connected` is possible to invoked more then once i.e. during test shutdown, the master closed the event stream making us call the `disconnected` callback. However, the master detector can still detect the same master and establish a connection to it while it is shutting down leading to `connected` callback be invoked again in some cases.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
> src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
>
> Diff: https://reviews.apache.org/r/43667/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43667: Modified existing scheduler tests as an
aftermath of pipelining change.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 4:45 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Merged r43664 with this review.
Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570
Repository: mesos
Description
-------
This change modifies the existing tests to handle the new `connected/disconnected` semantics that were introduced as a result of the pipelining change.
Now `connected` is possible to invoked more then once i.e. during test shutdown, the master closed the event stream making us call the `disconnected` callback. However, the master detector can still detect the same master and establish a connection to it while it is shutting down leading to `connected` callback be invoked again in some cases.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43667/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43667: Modified existing scheduler tests as an
aftermath of pipelining change.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/#review119575
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43664, 43667]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 17, 2016, 10:46 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43667/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing tests to handle the new `connected/disconnected` semantics that were introduced as a result of the pipelining change.
>
> Now `connected` is possible to invoked more then once i.e. during test shutdown, the master closed the event stream making us call the `disconnected` callback. However, the master detector can still detect the same master and establish a connection to it while it is shutting down leading to `connected` callback be invoked again in some cases.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
> src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
>
> Diff: https://reviews.apache.org/r/43667/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43667: Modified existing scheduler tests as an
aftermath of pipelining change.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
-----------------------------------------------------------
(Updated Feb. 17, 2016, 10:46 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Modified Maintenance tests.
Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570
Repository: mesos
Description
-------
This change modifies the existing tests to handle the new `connected/disconnected` semantics that were introduced as a result of the pipelining change.
Now `connected` is possible to invoked more then once i.e. during test shutdown, the master closed the event stream making us call the `disconnected` callback. However, the master detector can still detect the same master and establish a connection to it while it is shutting down leading to `connected` callback be invoked again in some cases.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43667/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar