[GitHub] [flink] leonardBang commented on a change in pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog

[GitBox <gi...@apache.org>]

leonardBang commented on a change in pull request #12090:
URL: https://github.com/apache/flink/pull/12090#discussion_r427076675



##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalog.java
##########
@@ -258,6 +256,8 @@ private DataType fromJDBCType(ResultSetMetaData metadata, int colIndex) throws S
 		int precision = metadata.getPrecision(colIndex);
 		int scale = metadata.getScale(colIndex);
 
+		// pg types that gets replaced by jdbc driver:
+	    // - decimal => numeric

Review comment:
       The note looks strange after we removed decimal switch, how about remove this note or list all alias :
   >    // Postgres jdbc driver maps several alias to real type, we use real type rather than alias.
   	// smallint <=> int2
   	// integer <=> int4
   	// int <=> int4
   	// bigint <=> int8
   	// float <=> float8
   	// boolean <=> bool
   	// decimal <=> numeric
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org