You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/21 05:14:55 UTC
[GitHub] [flink] chermenin commented on a change in pull request #8022:
[FLINK-11968] [runtime] Fixed SingleElementIterator and removed duplicate
chermenin commented on a change in pull request #8022: [FLINK-11968] [runtime] Fixed SingleElementIterator and removed duplicate
URL: https://github.com/apache/flink/pull/8022#discussion_r267627267
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/SingleElementIterator.java
##########
@@ -64,6 +64,7 @@ public void remove() {
@Override
public Iterator<E> iterator() {
+ available = true;
Review comment:
@wuchong In my opinion, we even need to return a new instance of the iterator and use `set()` method with `current` as the argument, to avoid modifications of the current instance. How do you look at that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services