You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/23 01:19:55 UTC
[GitHub] [spark] HeartSaVioR commented on a change in pull request #30885: [SPARK-33659][SS] Document the current behavior for DataStreamWriter.toTable API
HeartSaVioR commented on a change in pull request #30885:
URL: https://github.com/apache/spark/pull/30885#discussion_r547588398
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -301,12 +301,24 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
def start(): StreamingQuery = startInternal(None)
/**
+ * :: Experimental ::
+ *
* Starts the execution of the streaming query, which will continually output results to the given
* table as new data arrives. A new table will be created if the table not exists. The returned
Review comment:
+1 to @viirya suggestion. My request was to describe the impact of options (mostly partitionBy) for matrix of v1 vs v2 and existing vs non-existing.
Separating the case of v1 vs v2 is more important, so the suggestion looks better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org