[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42913: [SPARK-45081][SQL][3.4] Encoders.bean does no longer work with read-only properties

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42913:
URL: https://github.com/apache/spark/pull/42913#discussion_r1329158225


##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:
##########
@@ -1711,6 +1711,23 @@ public void testEmptyBean() {
     Assert.assertEquals(1, df.collectAsList().size());
   }
 
+  public static class ReadOnlyPropertyBean implements Serializable {
+      public boolean isEmpty() {

Review Comment:
   We use 2-space indentation. Could you fix the style, @gbloisi-openaire ?



##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:
##########
@@ -1711,6 +1711,23 @@ public void testEmptyBean() {
     Assert.assertEquals(1, df.collectAsList().size());
   }
 
+  public static class ReadOnlyPropertyBean implements Serializable {
+      public boolean isEmpty() {

Review Comment:
   We use 2-space indentation even in Java code. Could you fix the style, @gbloisi-openaire ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org