[jira] [Commented] (SOLR-17654) DistribFileStore._getRealPath() has issues on Windows

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924722#comment-17924722 ] 

ASF subversion and git services commented on SOLR-17654:
--------------------------------------------------------

Commit d0ec48f1c5aa8b711eeb4a951499d06bf0b438b9 in solr's branch refs/heads/main from Matthew Biscocho
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=d0ec48f1c5a ]

SOLR-17654: Fix DistribFileStore._getRealPath() for Windows (#3160)

Revert but use NIO API to obtain path separator

> DistribFileStore._getRealPath() has issues on Windows
> -----------------------------------------------------
>
>                 Key: SOLR-17654
>                 URL: https://issues.apache.org/jira/browse/SOLR-17654
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Houston Putman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> On Windows, many tests that use the DistribFileStore, such as {{TestPackages}}, {{TestDistribFileStore}} and {{PackageToolTest}} are failing because of an issue in {{DistribFileStore._getRealPath()}}.
> This method tries to remove the beginning slashes from the path, and then tries to make a new path relative to the file store location. However, in the tests, it's failing and showing stuff like "Illegal path \mypkg\v.0.12\jar_a.jar". Clearly in the code, the first "\" should have been removed, so this code is having an issue with Windows.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org