You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2024/12/12 16:12:47 UTC
[I] FABAuthManager migrate endpoints to FastAPI [airflow]
pierrejeambrun opened a new issue, #44881:
URL: https://github.com/apache/airflow/issues/44881
### Body
Depends on: https://github.com/apache/airflow/issues/44847
FABAuthManager defines extra flask endpoints.
As part of the migration to FastAPI these endpoints need to be converted to FastAPI.
Endpoints located in `airflow/providers/fab/auth_manager/api_endpoints` needs to be converted to FastAPI. (Duplicated for now, legacy flask endpoint will be removed later)
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2548974874
Related to the discussion in #44883, we likely don't need to actually rewrite or convert these, just wrap them with WSGIMiddleware when auth managers start exposing fastapi subapps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2605752376
Yeah, and #45009 is already doing that mounting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "andreimek (via GitHub)" <gi...@apache.org>.
andreimek commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2539811935
Hi @pierrejeambrun,
I would like to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2594378440
Hey @andreimek , did you get a chance to work on this issue? Please do let us know if you need any help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2539401597
cc: @vincbeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2541149469
Assigned to you @andreimek , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham closed issue #44881: FABAuthManager migrate endpoints to FastAPI
URL: https://github.com/apache/airflow/issues/44881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] FABAuthManager migrate endpoints to FastAPI [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on issue #44881:
URL: https://github.com/apache/airflow/issues/44881#issuecomment-2605661452
Should we close this one? My understanding is we will not migrate the endpoints but just embed the Flask endpoint into the Fastapi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org