You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/01 07:50:41 UTC
[GitHub] [incubator-apisix] renyineng opened a new pull request #1096: add
cors plugin
renyineng opened a new pull request #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
### Summary
SUMMARY_HERE
### Full changelog
add cors plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1096: add cors
plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-583202950
@renyineng any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1096: add cors
plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-605868042
closed by https://github.com/apache/incubator-apisix/pull/1327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] Miss-you commented on issue #1096: add cors
plugin
Posted by GitBox <gi...@apache.org>.
Miss-you commented on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-581390467
A brief look at the code:
1. Need process the "Preflight Request." which is an "OPTIONS" request.
2. Need test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] Miss-you edited a comment on issue #1096: add
cors plugin
Posted by GitBox <gi...@apache.org>.
Miss-you edited a comment on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-581390467
A brief look at the code:
1. Need process the "Preflight Request." which is an "OPTIONS" request. It seems only supporting the simple requests.
2. Need test case.
3. The default value of the max_age suggestion is 24 hours, 86400.
4. Headers and other arrays need to use the string directly. Otherwise, each request needs to concatenate several tables into strings, which is obviously costly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] Miss-you edited a comment on issue #1096: add
cors plugin
Posted by GitBox <gi...@apache.org>.
Miss-you edited a comment on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-581390467
A brief look at the code:
1. Need process the "Preflight Request." which is an "OPTIONS" request. It seems only supporting the simple requests.
2. Need test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1096: add cors
plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-581023004
@Miss-you please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming closed pull request #1096: add cors
plugin
Posted by GitBox <gi...@apache.org>.
moonming closed pull request #1096: add cors plugin
URL: https://github.com/apache/incubator-apisix/pull/1096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services