You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2015/03/10 23:10:44 UTC
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/4968
[SPARK-6251] [mllib] Made optimize, setGradient be DeveloperApi in LBFGS, GradientDescent
Made optimize, setGradient be DeveloperApi in LBFGS, GradientDescent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark SPARK-6251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4968.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4968
----
commit d9ad3aefc12540b9de4db733a016b8b73ae8afa9
Author: Joseph K. Bradley <jo...@databricks.com>
Date: 2015-03-10T22:09:35Z
Made optimize, setGradient be DeveloperApi in LBFGS, GradientDescent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4968#issuecomment-78171684
[Test build #28444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28444/consoleFull) for PR 4968 at commit [`d9ad3ae`](https://github.com/apache/spark/commit/d9ad3aefc12540b9de4db733a016b8b73ae8afa9).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4968#issuecomment-78171694
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28444/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4968#issuecomment-78159963
[Test build #28444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28444/consoleFull) for PR 4968 at commit [`d9ad3ae`](https://github.com/apache/spark/commit/d9ad3aefc12540b9de4db733a016b8b73ae8afa9).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4968#discussion_r26173416
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -92,9 +92,11 @@ class LBFGS(private var gradient: Gradient, private var updater: Updater)
}
/**
+ * :: DeveloperApi ::
* Set the gradient function (of the loss function of one single data example)
* to be used for L-BFGS.
*/
+ @DeveloperApi
--- End diff --
The `LBFGS` class is marked `DeveloperApi`. Do we still need to mark its members?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4968#discussion_r26175220
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -92,9 +92,11 @@ class LBFGS(private var gradient: Gradient, private var updater: Updater)
}
/**
+ * :: DeveloperApi ::
* Set the gradient function (of the loss function of one single data example)
* to be used for L-BFGS.
*/
+ @DeveloperApi
--- End diff --
Some of its members are public API:
* numCorrections
* convergenceTol
* numIterations
* regParam
* updater
This JIRA/PR could make LBFGS non-DeveloperApi. Or we could leave this as another to-do item for when we bit the bullet and refactor all the optimization code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4968#issuecomment-87862553
I'll close this since the optimization API needs to be revamped anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6251] [mllib] Made optimize, setGradien...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley closed the pull request at:
https://github.com/apache/spark/pull/4968
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org