You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/22 16:41:43 UTC
[GitHub] [pinot] weixiangsun opened a new pull request #8383: Deprecate the PostAggregationGapfill.
weixiangsun opened a new pull request #8383:
URL: https://github.com/apache/pinot/pull/8383
## Description
Deprecate the PostAggregationGapfill.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #8383: Deprecate the PostAggregationGapfill.
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #8383:
URL: https://github.com/apache/pinot/pull/8383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] weixiangsun commented on a change in pull request #8383: Deprecate the PostAggregationGapfill.
Posted by GitBox <gi...@apache.org>.
weixiangsun commented on a change in pull request #8383:
URL: https://github.com/apache/pinot/pull/8383#discussion_r832430901
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java
##########
@@ -189,15 +171,15 @@ public static GapfillType getGapfillType(QueryContext queryContext) {
Preconditions.checkArgument(gapFillSelection != null && gapFillSelection.getFunction() != null,
"Gapfill Expression should be function.");
List<ExpressionContext> args = gapFillSelection.getFunction().getArguments();
- Preconditions.checkArgument(args.size() > 5, "PreAggregateGapFill does not have correct number of arguments.");
+ Preconditions.checkArgument(args.size() > 5, "GapFill does not have correct number of arguments.");
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8383: Deprecate the PostAggregationGapfill.
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8383:
URL: https://github.com/apache/pinot/pull/8383#discussion_r832426342
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java
##########
@@ -189,15 +171,15 @@ public static GapfillType getGapfillType(QueryContext queryContext) {
Preconditions.checkArgument(gapFillSelection != null && gapFillSelection.getFunction() != null,
"Gapfill Expression should be function.");
List<ExpressionContext> args = gapFillSelection.getFunction().getArguments();
- Preconditions.checkArgument(args.size() > 5, "PreAggregateGapFill does not have correct number of arguments.");
+ Preconditions.checkArgument(args.size() > 5, "GapFill does not have correct number of arguments.");
Review comment:
(minor) Treat `Gapfill` as one word, same for other exception messages
```suggestion
Preconditions.checkArgument(args.size() > 5, "Gapfill does not have correct number of arguments.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org