[GitHub] [flink] zhijiangW commented on a change in pull request #8948: [FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool

[GitBox <gi...@apache.org>]

zhijiangW commented on a change in pull request #8948: [FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool
URL: https://github.com/apache/flink/pull/8948#discussion_r299789891
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -211,14 +225,17 @@ protected StreamTask(Environment env) {
 	 *
 	 * @param environment The task environment for this task.
 	 * @param timeProvider Optionally, a specific time provider to use.
+	 * @param uncaughtExceptionHandler to handle uncaught exceptions in the async operations thread pool
 	 */
 	protected StreamTask(
 			Environment environment,
-			@Nullable ProcessingTimeService timeProvider) {
+			@Nullable ProcessingTimeService timeProvider,
+			Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
 
 		super(environment);
 
 		this.timerService = timeProvider;
+		this.uncaughtExceptionHandler = uncaughtExceptionHandler;
 
 Review comment:
   nit: checkNotNull(uncaughtExceptionHandler)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services