You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 09:52:09 UTC
[GitHub] [spark] yaooqinn commented on issue #27965:
[SPARK-29774][SQL][followup] support string literal as the second argument
of date_add/date_sub functions
yaooqinn commented on issue #27965: [SPARK-29774][SQL][followup] support string literal as the second argument of date_add/date_sub functions
URL: https://github.com/apache/spark/pull/27965#issuecomment-601614952
I'm -1 for such kind of restore.
1. It restores only string literal cases, not the non-literal column cases, so it makes these functions more complicated to understand.
2. the string literals have to be int-castable, this makes the scope even smaller. So, I'm wondering why a user might prefer an integer value with extra single quotes to the integer itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org