You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/07/25 01:17:06 UTC
Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/
-----------------------------------------------------------
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-1143
https://issues.apache.org/jira/browse/SQOOP-1143
Repository: sqoop-sqoop2
Description
-------
commit 79fef1510f3a309b582a9f31045237b837703d27
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Jul 23 16:51:53 2013 -0700
SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
:000000 100644 0000000... cfcbfd9... A core/src/main/java/org/apache/sqoop/core/AuditLogger.java
:000000 100644 0000000... 1f9e098... A core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java
:000000 100644 0000000... d48e93c... A core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java
:000000 100644 0000000... a8f0240... A core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java
:000000 100644 0000000... f7b7491... A core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
:100644 100644 90bb327... 9b02be2... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
:100755 100755 76596b4... 2aba0a1... M dist/src/main/server/conf/sqoop.properties
:100644 100644 038f602... 093ab95... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 4c389cc... 9528564... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
:100644 100644 04ffc3c... dbf6496... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
:100644 100644 ab3f9d0... 50ccd26... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... f15da7b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 f92d107... 7b59a81... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
Diffs
-----
core/src/main/java/org/apache/sqoop/core/AuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
dist/src/main/server/conf/sqoop.properties 76596b4
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
Diff: https://reviews.apache.org/r/12932/diff/
Testing
-------
Do some manual test for new functionalities.
Unit test passed.
Thanks,
Mengwei Ding
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Mengwei Ding <me...@gmail.com>.
> On July 30, 2013, 12:53 a.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java, lines 84-90
> > <https://reviews.apache.org/r/12932/diff/2/?file=330199#file330199line84>
> >
> > I would suggest to set both initial and last log message to "info".
Yes. Should notice that.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review24181
-----------------------------------------------------------
On Aug. 2, 2013, 9:34 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:34 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e1043afccdafc866b376df812f3a6fd7976f777a
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
> :000000 100644 0000000... d056a34... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
> :000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
> :000000 100644 0000000... 17a996f... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
> :000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
> :100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review24181
-----------------------------------------------------------
Hi Mengwei,
thank for incorporating my feedback!
core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
<https://reviews.apache.org/r/12932/#comment48004>
Nit: I'm not familiar with word "surfix", shouldn't it be "suffix"?
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
<https://reviews.apache.org/r/12932/#comment48003>
Nit: I believe that this constant is no longer necessary?
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
<https://reviews.apache.org/r/12932/#comment48006>
I would suggest to set both initial and last log message to "info".
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
<https://reviews.apache.org/r/12932/#comment48005>
Can we please add logging output describing that such and such audit logger was initialized here?
Jarcec
- Jarek Cecho
On July 29, 2013, 8:02 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 8:02 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 9ebaf0aad64b690c378188d2c53d6dcd0cd30ddb
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
> :000000 100644 0000000... 9e27d7c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
> :000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
> :000000 100644 0000000... 2c1075a... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
> :000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
> :100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review25148
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 2, 2013, 9:34 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:34 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e1043afccdafc866b376df812f3a6fd7976f777a
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
> :000000 100644 0000000... d056a34... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
> :000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
> :000000 100644 0000000... 17a996f... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
> :000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
> :100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 9:34 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
made changes based on review comments.
Bugs: SQOOP-1143
https://issues.apache.org/jira/browse/SQOOP-1143
Repository: sqoop-sqoop2
Description (updated)
-------
commit e1043afccdafc866b376df812f3a6fd7976f777a
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Jul 23 16:51:53 2013 -0700
SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
:000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
:000000 100644 0000000... d056a34... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
:000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
:000000 100644 0000000... 17a996f... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
:000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
:100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
:100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
:100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
:100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
:100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
dist/src/main/server/conf/sqoop.properties 76596b4
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
Diff: https://reviews.apache.org/r/12932/diff/
Testing
-------
Do some manual test for new functionalities.
Unit test passed.
Thanks,
Mengwei Ding
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/
-----------------------------------------------------------
(Updated July 29, 2013, 8:02 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
Make changes based on Jarcec's suggestions. Thank you, Jarcec.
Bugs: SQOOP-1143
https://issues.apache.org/jira/browse/SQOOP-1143
Repository: sqoop-sqoop2
Description (updated)
-------
commit 9ebaf0aad64b690c378188d2c53d6dcd0cd30ddb
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Jul 23 16:51:53 2013 -0700
SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
:000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
:000000 100644 0000000... 9e27d7c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
:000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
:000000 100644 0000000... 2c1075a... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
:000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
:100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
:100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
:100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
:100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
:100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
dist/src/main/server/conf/sqoop.properties 76596b4
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
Diff: https://reviews.apache.org/r/12932/diff/
Testing
-------
Do some manual test for new functionalities.
Unit test passed.
Thanks,
Mengwei Ding
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Mengwei Ding <me...@gmail.com>.
> On July 28, 2013, 4:03 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java, line 27
> > <https://reviews.apache.org/r/12932/diff/1/?file=327692#file327692line27>
> >
> > I would suggest to convert this class to a "FileAuditLogger" and put the default configuration into the default sqoop.properties configuration file. Benefit of that will be that user can easily configure two FileAuditLoggers and log to two places if necessary.
Yeah, make sense. Thank you, Jarcec.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review24061
-----------------------------------------------------------
On July 24, 2013, 11:17 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 11:17 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 79fef1510f3a309b582a9f31045237b837703d27
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... cfcbfd9... A core/src/main/java/org/apache/sqoop/core/AuditLogger.java
> :000000 100644 0000000... 1f9e098... A core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java
> :000000 100644 0000000... d48e93c... A core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java
> :000000 100644 0000000... a8f0240... A core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java
> :000000 100644 0000000... f7b7491... A core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
> :100644 100644 90bb327... 9b02be2... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... 2aba0a1... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 038f602... 093ab95... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... 9528564... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... dbf6496... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 ab3f9d0... 50ccd26... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... f15da7b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 7b59a81... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Mengwei Ding <me...@gmail.com>.
> On July 28, 2013, 4:03 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/core/AuditLogger.java, line 18
> > <https://reviews.apache.org/r/12932/diff/1/?file=327688#file327688line18>
> >
> > I would suggest to put all the audit related classes to it's own package "org.apache.sqoop.core.audit".
Thank you, Jarcec.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review24061
-----------------------------------------------------------
On July 24, 2013, 11:17 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 11:17 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 79fef1510f3a309b582a9f31045237b837703d27
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... cfcbfd9... A core/src/main/java/org/apache/sqoop/core/AuditLogger.java
> :000000 100644 0000000... 1f9e098... A core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java
> :000000 100644 0000000... d48e93c... A core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java
> :000000 100644 0000000... a8f0240... A core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java
> :000000 100644 0000000... f7b7491... A core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
> :100644 100644 90bb327... 9b02be2... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... 2aba0a1... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 038f602... 093ab95... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... 9528564... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... dbf6496... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 ab3f9d0... 50ccd26... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... f15da7b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 7b59a81... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review24061
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this JIRA!
core/src/main/java/org/apache/sqoop/core/AuditLogger.java
<https://reviews.apache.org/r/12932/#comment47904>
I would suggest to put all the audit related classes to it's own package "org.apache.sqoop.core.audit".
core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java
<https://reviews.apache.org/r/12932/#comment47906>
I would recommend to not have this fallback solution in case that no audit loggers are defined. Running without audit logs might be a valid use case.
core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
<https://reviews.apache.org/r/12932/#comment47905>
I would suggest to convert this class to a "FileAuditLogger" and put the default configuration into the default sqoop.properties configuration file. Benefit of that will be that user can easily configure two FileAuditLoggers and log to two places if necessary.
core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
<https://reviews.apache.org/r/12932/#comment47908>
Nit the default file path is invalid as the "@LOGDIR" is just a placeholder that should be substituted in the configuration file. I would suggest to simply require specifying the file by user.
core/src/main/java/org/apache/sqoop/core/SqoopServer.java
<https://reviews.apache.org/r/12932/#comment47907>
I would suggest to change the order and put the AuditLogger just after the SqoopConfiguration (as it do not have any further dependencies).
Jarcec
- Jarek Cecho
On July 24, 2013, 11:17 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 11:17 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 79fef1510f3a309b582a9f31045237b837703d27
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... cfcbfd9... A core/src/main/java/org/apache/sqoop/core/AuditLogger.java
> :000000 100644 0000000... 1f9e098... A core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java
> :000000 100644 0000000... d48e93c... A core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java
> :000000 100644 0000000... a8f0240... A core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java
> :000000 100644 0000000... f7b7491... A core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java
> :100644 100644 90bb327... 9b02be2... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... 2aba0a1... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 038f602... 093ab95... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... 9528564... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... dbf6496... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 ab3f9d0... 50ccd26... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... f15da7b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 7b59a81... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/DefaultAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 038f602
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java ab3f9d0
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>