You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "tkhurana (via GitHub)" <gi...@apache.org> on 2024/04/05 17:32:02 UTC
[PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
tkhurana opened a new pull request, #1874:
URL: https://github.com/apache/phoenix/pull/1874
Fix paging for scans with limit but no other filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1874:
URL: https://github.com/apache/phoenix/pull/1874#issuecomment-2040502453
Really nice find btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on code in PR #1874:
URL: https://github.com/apache/phoenix/pull/1874#discussion_r1554186077
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ScanUtil.java:
##########
@@ -1615,14 +1615,21 @@ public static boolean isIncompatibleClientForServerReturnValidRowKey(Scan scan)
public static PageFilter removePageFilter(Scan scan) {
Filter filter = scan.getFilter();
if (filter != null) {
+ PagingFilter pagingFilter = null;
if (filter instanceof PagingFilter) {
- filter = ((PagingFilter) filter).getDelegateFilter();
+ pagingFilter = (PagingFilter) filter;
+ filter = pagingFilter.getDelegateFilter();
if (filter == null) {
return null;
}
}
if (filter instanceof PageFilter) {
- scan.setFilter(null);
+ if (pagingFilter != null) {
+ pagingFilter.setDelegateFilter(null);
+ scan.setFilter(pagingFilter);
Review Comment:
Yes, the LIMIT translates to HBase PageFilter and the Phoenix PagingFilter prevents rpc timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on PR #1874:
URL: https://github.com/apache/phoenix/pull/1874#issuecomment-2040682304
Test results look good. 2 tests failed. Known flappers
[ERROR] Failures:
[ERROR] WALRecoveryRegionPostOpenIT.testRecoveryRegionPostOpen
[ERROR] org.apache.phoenix.end2end.index.MutableIndexFailureIT.testIndexWriteFailure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana merged PR #1874:
URL: https://github.com/apache/phoenix/pull/1874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7302 Server Paging doesn't work on scans with limit [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #1874:
URL: https://github.com/apache/phoenix/pull/1874#discussion_r1554179954
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ScanUtil.java:
##########
@@ -1615,14 +1615,21 @@ public static boolean isIncompatibleClientForServerReturnValidRowKey(Scan scan)
public static PageFilter removePageFilter(Scan scan) {
Filter filter = scan.getFilter();
if (filter != null) {
+ PagingFilter pagingFilter = null;
if (filter instanceof PagingFilter) {
- filter = ((PagingFilter) filter).getDelegateFilter();
+ pagingFilter = (PagingFilter) filter;
+ filter = pagingFilter.getDelegateFilter();
if (filter == null) {
return null;
}
}
if (filter instanceof PageFilter) {
- scan.setFilter(null);
+ if (pagingFilter != null) {
+ pagingFilter.setDelegateFilter(null);
+ scan.setFilter(pagingFilter);
Review Comment:
This helps when filter is of both types: HBase PageFilter and Phoenix PagingFilter (which happens only when LIMIT is present), so that we want to retain PagingFilter for performing page timeouts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org