You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/04 22:18:37 UTC
[GitHub] [incubator-mxnet] samskalicky opened a new pull request #18236: [1.7] Pass args fix2
samskalicky opened a new pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236
## Description ##
Cherry pick #18232
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-634123665
According to https://github.com/iusrepo/announce/issues/18 we need to change the path we use to install python in ci/docker/install/centos7_python.sh from https://centos7.iuscommunity.org/ius-release.rpm to https://repo.ius.io/ius-release-el7.rpm. Ive updated it, lets see if it passes CI now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-633208004
Hi @samskalicky , there's several PRs struggling with the CI failure so far. @waytrue17 is working on the fix of `edge` job (`NVidia Jetson / ARMv8`). While for the `centos-gpu` and `centos-cpu` jobs in this PR failed for `Cannot open: https://centos7.iuscommunity.org/ius-release.rpm. Skipping.`, can you help to take a check? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18236: [1.7] Pass args fix2
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-634350965
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632819992
@ciyongch looks like the CI is currently broken for 1.x per @leezu
does this block the 1.7 release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632239843
@ciyongch thanks for the reminder, I merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-626285058
https://github.com/apache/incubator-mxnet/blob/80baab83775d54b1805a72254992a0fa87bd2f49/ci/docker/install/requirements#L30-L31
This has already been resolved in my PR #18220
https://github.com/apache/incubator-mxnet/pull/18220/commits/18e2014004eb52e34db926d47202f1add5ff817f
@samskalicky please rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-631902011
HI @samskalicky , please help to rebase to remove the conflicts :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18236: [1.7] Pass args fix2
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-634380782
Hi @samskalicky , probably rename the title to [1.x] instead of [1.7] for this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632791542
@mxnet-bot run ci [edge, windows-gpu, centos-cpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.x] Pass args fix2
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-634987282
@mxnet-label-bot update [pr-awaiting-merge]
@ciyongch I updated the title, @leezu ready to merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] apeforest merged pull request #18236: [1.x] Pass args fix2
Posted by GitBox <gi...@apache.org>.
apeforest merged pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632791604
Jenkins CI successfully triggered : [edge, centos-cpu, windows-gpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18236: [1.7] Pass args fix2
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-634351015
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18236: [1.7] Pass args fix2
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18236:
URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-623737803
Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, windows-cpu, windows-gpu, centos-gpu, edge, sanity, website, clang, unix-gpu, unix-cpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org