You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by gef756 <gi...@git.apache.org> on 2017/10/10 22:59:13 UTC

[GitHub] zeppelin pull request #2616: ZEPPELIN-2984: allow enter from username

GitHub user gef756 opened a pull request:

    https://github.com/apache/zeppelin/pull/2616

    ZEPPELIN-2984: allow enter from username

    ### What is this PR for?
    Allow an "Enter" keypress in the username field during login
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * N/A
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2984
    
    ### How should this be tested?
    * Pull up login screen. Fill in username and password. Click in username field.
      Press enter. We would expect the login handler to be called.
    * Pull up login screen. Fill in username and password. Press enter (while still
      in password field). We would expect the login handler to be called just as
      before.
    * Alternatively, use a password manager (e.g. LastPass). Save the password.
      Pull up the login screen. Press Enter. We would expect the login handler to be
      called.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gef756/zeppelin dev-login-enter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2616
    
----
commit 85c54d40ee1976561bb96b346c9438d773243183
Author: Gabe Fernando <ge...@gmail.com>
Date:   2017-10-09T22:24:27Z

    ENH: allow enter from username

----


---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2616
  
    Nowadays many browser support password auto-completion. (e.g Chrome, ...)
    So +1 for this feature. 


---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2616
  
    @gef756 Could u make CI green?


---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2616
  
    LGTM. Thanks @gef756 for the contribution!
    
    Merge to master if no further discussions.


---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

Posted by gef756 <gi...@git.apache.org>.

Github user gef756 commented on the issue:

    https://github.com/apache/zeppelin/pull/2616
  
    @1ambda Let me know if you need anything else! Just pulled in master again, and got CI green.


---

[GitHub] zeppelin pull request #2616: ZEPPELIN-2984: allow enter from username

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2616


---

[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

Posted by gef756 <gi...@git.apache.org>.

Github user gef756 commented on the issue:

    https://github.com/apache/zeppelin/pull/2616
  
    @1ambda Done. Green!


---