You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/26 19:55:10 UTC

[GitHub] [flink] afedulov opened a new pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

afedulov opened a new pull request #18525:
URL: https://github.com/apache/flink/pull/18525


   This PR continues work done in https://github.com/apache/flink/pull/15674 and addresses the remaining comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66673f493dad742ccbffae662907ff3deb299314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256) 
   * 946be7300738632c68e9f47bb9c128887876c885 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66673f493dad742ccbffae662907ff3deb299314 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022552083


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 66673f493dad742ccbffae662907ff3deb299314 (Wed Jan 26 19:58:10 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-22311).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 76dd84a175d0860c9db155b20bfe849b94e944d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] afedulov commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1026277566


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 946be7300738632c68e9f47bb9c128887876c885 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] afedulov commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022550864


   @rkhachatryan, PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 946be7300738632c68e9f47bb9c128887876c885 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341) 
   * 76dd84a175d0860c9db155b20bfe849b94e944d5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 946be7300738632c68e9f47bb9c128887876c885 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341) 
   * 76dd84a175d0860c9db155b20bfe849b94e944d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562",
       "triggerID" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4b52d45583abd9fb33478d9b90849da9939a24d7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66673f493dad742ccbffae662907ff3deb299314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256) 
   * 946be7300738632c68e9f47bb9c128887876c885 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rkhachatryan merged pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18525:
URL: https://github.com/apache/flink/pull/18525


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66673f493dad742ccbffae662907ff3deb299314 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66673f493dad742ccbffae662907ff3deb299314 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] afedulov commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1023581165


   Thanks, @rkhachatryan. I guess it is still needed, but on `JdbcExecutionOptions` instead of where I placed it (not sure what happened there :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] afedulov commented on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1023585914


   Fixed, the test passes now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562",
       "triggerID" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * 4b52d45583abd9fb33478d9b90849da9939a24d7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30562) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18525: [FLINK-22311] [connector/jdbc] Validate maxRetries for XA Sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18525:
URL: https://github.com/apache/flink/pull/18525#issuecomment-1022553453


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "66673f493dad742ccbffae662907ff3deb299314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30256",
       "triggerID" : "66673f493dad742ccbffae662907ff3deb299314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "946be7300738632c68e9f47bb9c128887876c885",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30341",
       "triggerID" : "946be7300738632c68e9f47bb9c128887876c885",
       "triggerType" : "PUSH"
     }, {
       "hash" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30385",
       "triggerID" : "76dd84a175d0860c9db155b20bfe849b94e944d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1026277566",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4b52d45583abd9fb33478d9b90849da9939a24d7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * 4b52d45583abd9fb33478d9b90849da9939a24d7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org