[jira] [Commented] (TS-1833) Deprecate TSMimeHdrFieldValueStringInsert() (and family)

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011678#comment-14011678 ] 

Leif Hedstrom commented on TS-1833:
-----------------------------------

I moved all this out to 6.0.0, but added a small comment to the include file.

> Deprecate TSMimeHdrFieldValueStringInsert() (and family)
> --------------------------------------------------------
>
>                 Key: TS-1833
>                 URL: https://issues.apache.org/jira/browse/TS-1833
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>              Labels: api-change
>             Fix For: 6.0.0
>
>
> It seems to be that TSMimeHdrFieldValueStringInsert() is really just a subset of TSMimeHdrFieldValueStringSet(). This just makes for confusing APIs, i.e. which one do I use when? The alternative would be to remove the "idx" argument to the TSMimeHdrFieldValueStringSet() method, but that would then break API and ABI compatibility.
> Also, as James found out, the docs are less than clear. Set() needs to be called with an idx of -1 for it to actually be a Set() operation. With idx >=0, TSMimeHdrFieldValueStringSet() is actually identical to TSMimeHdrFieldValueStringInsert()....



--
This message was sent by Atlassian JIRA
(v6.2#6252)