[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10436: feat(api): database schemas migration to new API

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #10436:
URL: https://github.com/apache/incubator-superset/pull/10436#discussion_r461606530



##########
File path: tests/database_api_tests.py
##########
@@ -252,6 +252,24 @@ def test_schemas(self):
         response = json.loads(rv.data.decode("utf-8"))
         self.assertEqual(0, len(response["result"]))
 
+    def test_database_schemas(self):

Review comment:
       This endpoint has no pagination, since if I'm not mistaken the dropdown does not support it yet

##########
File path: tests/database_api_tests.py
##########
@@ -252,6 +252,24 @@ def test_schemas(self):
         response = json.loads(rv.data.decode("utf-8"))
         self.assertEqual(0, len(response["result"]))
 
+    def test_database_schemas(self):

Review comment:
       It would be super useful on the SQLLab database dropdown




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org