You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/15 15:56:14 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23716: Add typing for airflow/configuration.py
potiuk opened a new pull request, #23716:
URL: https://github.com/apache/airflow/pull/23716
The configuraiton.py did not have typing information and it made
it rather difficult to reason about it-especially that it went
a few changes in the past that made it rather complex to
understand.
This PR adds typing information all over the configuration file
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] skyboi1233 commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
skyboi1233 commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1128218089
This was not me I didn’t approve this it didn’t come from me
Sent from Yahoo Mail for iPhone
On Monday, May 16, 2022, 4:20 PM, Jarek Potiuk ***@***.***> wrote:
Merged #23716 into main.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23716:
URL: https://github.com/apache/airflow/pull/23716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1126969439
Just to get a `little` more sanity on our configuration implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1127330909
OK. I hope I have all static checks fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1128051707
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #23716:
URL: https://github.com/apache/airflow/pull/23716#discussion_r874121701
##########
airflow/configuration.py:
##########
@@ -620,15 +666,17 @@ def getjson(self, section, key, fallback=_UNSET, **kwargs) -> Union[dict, list,
except (NoSectionError, NoOptionError):
return default
- if len(data) == 0:
+ if data is None or len(data) == 0:
Review Comment:
Why not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1127491050
All green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a diff in pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
turbaszek commented on code in PR #23716:
URL: https://github.com/apache/airflow/pull/23716#discussion_r874075904
##########
airflow/configuration.py:
##########
@@ -620,15 +666,17 @@ def getjson(self, section, key, fallback=_UNSET, **kwargs) -> Union[dict, list,
except (NoSectionError, NoOptionError):
return default
- if len(data) == 0:
+ if data is None or len(data) == 0:
Review Comment:
```suggestion
if not data:
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23716: Add typing for airflow/configuration.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23716:
URL: https://github.com/apache/airflow/pull/23716#issuecomment-1126969222
cc: @pingzh - prerequisite to understand and fix #23679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org