You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/19 08:04:32 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request, #9106: [fix](transaction) Fix running transaction num always be zero when execute show proc '/transactions' stmt
caiconghui opened a new pull request, #9106:
URL: https://github.com/apache/incubator-doris/pull/9106
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9106: [fix](transaction) Fix running transaction num may be zero if there are running transactions when when execute show proc '/transactions' stmt
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9106:
URL: https://github.com/apache/incubator-doris/pull/9106#discussion_r854767848
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -124,10 +124,10 @@ public class DatabaseTransactionMgr {
// count the number of running txns of database, except for the routine load txn
- private int runningTxnNums = 0;
+ private volatile int runningTxnNums = 0;
// count only the number of running routine load txns of database
- private int runningRoutineLoadTxnNums = 0;
+ private volatile int runningRoutineLoadTxnNums = 0;
Review Comment:
Do we meet errors using int? If there are any errors, I think you'd better add comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9106: [fix](transaction) Fix running transaction num may be zero if there are running transactions when when execute show proc '/transactions' stmt
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9106:
URL: https://github.com/apache/incubator-doris/pull/9106#issuecomment-1104702360
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9106: [fix](transaction) Fix running transaction num may be zero if there are running transactions when when execute show proc '/transactions' stmt
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9106:
URL: https://github.com/apache/incubator-doris/pull/9106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9106: [fix](transaction) Fix running transaction num may be zero if there are running transactions when when execute show proc '/transactions' stmt
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9106:
URL: https://github.com/apache/incubator-doris/pull/9106#issuecomment-1104702347
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org