You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/28 02:27:12 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
mbien opened a new pull request, #4877:
URL: https://github.com/apache/netbeans/pull/4877
fixes #4876
we can't add it right away, otherwise the window can't layout itself without hardcoding the size of the scrollpane. Changing window size once its visible would look weird.
targets delivery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] errael commented on a diff in pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
errael commented on code in PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#discussion_r1008772429
##########
platform/o.n.core/src/org/netbeans/core/ui/ProductInformationPanel.java:
##########
@@ -102,6 +103,7 @@ public ProductInformationPanel() {
final String updates = getUpdates();
SwingUtilities.invokeLater(() -> {
description.setText(LBL_description(getProductVersionValue(), getJavaValue(), getVMValue(), getOperatingSystemValue(), getEncodingValue(), getSystemLocaleValue(), getUserDirValue(), Places.getCacheDirectory().getAbsolutePath(), updates, FONT_SIZE, getJavaRuntime()));
+ descriptionScrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS); // will need a scrollbar now
Review Comment:
It's not clear to me what `now` is referring to in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#issuecomment-1295577582
@neilcsmith-net this is a minor low risk bug fix for delivery.
enables the scrollbar if the "Updates:" text appears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#issuecomment-1295775241
@mbien already seen and on the radar. Looks good, makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#discussion_r1008773546
##########
platform/o.n.core/src/org/netbeans/core/ui/ProductInformationPanel.java:
##########
@@ -102,6 +103,7 @@ public ProductInformationPanel() {
final String updates = getUpdates();
SwingUtilities.invokeLater(() -> {
description.setText(LBL_description(getProductVersionValue(), getJavaValue(), getVMValue(), getOperatingSystemValue(), getEncodingValue(), getSystemLocaleValue(), getUserDirValue(), Places.getCacheDirectory().getAbsolutePath(), updates, FONT_SIZE, getJavaRuntime()));
+ descriptionScrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS); // will need a scrollbar now
Review Comment:
the moment the description text is updated. Which is what the lambda does. So at the point in time this lambda runs. [Now](https://youtu.be/fIyYTN86_Uk?t=91) basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4877:
URL: https://github.com/apache/netbeans/pull/4877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] errael commented on a diff in pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
errael commented on code in PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#discussion_r1008774363
##########
platform/o.n.core/src/org/netbeans/core/ui/ProductInformationPanel.java:
##########
@@ -102,6 +103,7 @@ public ProductInformationPanel() {
final String updates = getUpdates();
SwingUtilities.invokeLater(() -> {
description.setText(LBL_description(getProductVersionValue(), getJavaValue(), getVMValue(), getOperatingSystemValue(), getEncodingValue(), getSystemLocaleValue(), getUserDirValue(), Places.getCacheDirectory().getAbsolutePath(), updates, FONT_SIZE, getJavaRuntime()));
+ descriptionScrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS); // will need a scrollbar now
Review Comment:
Thanks, I was confused by the title ".... scrollbar if the async plugin update..." but it's a little more like
"... scrollbar in case the async plugin update...".
I had thought it might mean now that there are updates available.
So the scrollbar is there, even when there are no updates available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4877: about panel needs a vertical scrollbar if the async plugin update notification appears
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4877:
URL: https://github.com/apache/netbeans/pull/4877#discussion_r1008773546
##########
platform/o.n.core/src/org/netbeans/core/ui/ProductInformationPanel.java:
##########
@@ -102,6 +103,7 @@ public ProductInformationPanel() {
final String updates = getUpdates();
SwingUtilities.invokeLater(() -> {
description.setText(LBL_description(getProductVersionValue(), getJavaValue(), getVMValue(), getOperatingSystemValue(), getEncodingValue(), getSystemLocaleValue(), getUserDirValue(), Places.getCacheDirectory().getAbsolutePath(), updates, FONT_SIZE, getJavaRuntime()));
+ descriptionScrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS); // will need a scrollbar now
Review Comment:
the moment the description text is updated. Which is what the lambda does. So at the point this lambda runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists