You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2012/06/10 12:52:42 UTC
[jira] [Created] (MYFACES-3564) [perf] remove viewId sent inside
token in HtmlResponseStateManager
Leonardo Uribe created MYFACES-3564:
---------------------------------------
Summary: [perf] remove viewId sent inside token in HtmlResponseStateManager
Key: MYFACES-3564
URL: https://issues.apache.org/jira/browse/MYFACES-3564
Project: MyFaces Core
Issue Type: Sub-task
Components: JSR-314
Reporter: Leonardo Uribe
The current default implementation of HtmlResponseStateManager sends the viewId inside the token for server side state saving and client side state saving, but it is just useless information, because it is not used in any way.
Instead, JSF 2.0 spec defines that the viewId is derived in RestoreViewPhase from the url, following a specified set of rules (see restoreViewSupport.calculateViewId() ).
In server side state saving the viewId is used as part of the key used to restore the state from session map, which is reasonable.
The proposed change involves do not add this information into the token, because it is useless. Anyway, in client side state saving it has sense to send the viewId or some similar information into the state, and include a logic to check if the viewId match with the calculated viewId, to ensure the state can be applied to the expected view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3564) [perf] remove viewId sent inside
token in HtmlResponseStateManager
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-3564.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.1.9
2.0.15
Assignee: Leonardo Uribe
> [perf] remove viewId sent inside token in HtmlResponseStateManager
> ------------------------------------------------------------------
>
> Key: MYFACES-3564
> URL: https://issues.apache.org/jira/browse/MYFACES-3564
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: JSR-314
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.15, 2.1.9
>
>
> The current default implementation of HtmlResponseStateManager sends the viewId inside the token for server side state saving and client side state saving, but it is just useless information, because it is not used in any way.
> Instead, JSF 2.0 spec defines that the viewId is derived in RestoreViewPhase from the url, following a specified set of rules (see restoreViewSupport.calculateViewId() ).
> In server side state saving the viewId is used as part of the key used to restore the state from session map, which is reasonable.
> The proposed change involves do not add this information into the token, because it is useless. Anyway, in client side state saving it has sense to send the viewId or some similar information into the state, and include a logic to check if the viewId match with the calculated viewId, to ensure the state can be applied to the expected view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira