You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2024/07/10 08:13:41 UTC

Re: [PR] OPENNLP-1592 Provide tests for MetaSummarizer - performance improvement (opennlp-sandbox)

mawiesne commented on PR #155:
URL: https://github.com/apache/opennlp-sandbox/pull/155#issuecomment-2219844426

   > Assuming there is no risk of having issues (concurrent access, shared access by different users/callers incorrectly, etc.) by making the dictionary static instead of one per instance, I think this looks like a great improvement! 👍
   
   Good point. From what I see in the source of `edu.mit.jwi.RamDirectory`, no changes are possible once the dictionary is populated at constructor level. After initialization only read access is made via the API of that class.
   
   IMHO, we are good to go, to use it as a static resource here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org