You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Marko Sibakov (JIRA)" <ji...@apache.org> on 2008/10/06 22:23:44 UTC
[jira] Created: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
----------------------------------------------------------------------------------------------
Key: BUILDR-165
URL: https://issues.apache.org/jira/browse/BUILDR-165
Project: Buildr
Issue Type: Improvement
Components: IDE
Affects Versions: 1.3.3
Reporter: Marko Sibakov
Fix For: 1.3.4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644804#action_12644804 ]
Timo Rantalaiho commented on BUILDR-165:
----------------------------------------
Sorry for the delay and thanks for the good work, works like a charm!
I tested a couple of projects with IDEA 7 and 8 and some more with IDEA 7, and everything is working. Obviously I was testing artifacts:sources as well.
buildr idea still produces the "old" format files (IDEA 6 maybe?) but both IDEA 7 and IDEA 8 seem to handle them just fine. At some moments it could be upgraded to do IDEA 8 format, but it's not important for now.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton reassigned BUILDR-165:
-----------------------------
Assignee: lacton
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on BUILDR-165 started by lacton.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work stopped: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on BUILDR-165 stopped by lacton.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638890#action_12638890 ]
Timo Rantalaiho commented on BUILDR-165:
----------------------------------------
lacton, I think that downloading is better handled when downloading the artifacts. When an artifact dependency is updated (which might even be without changing the IDE files, in the case of snapshot dependencies), the source attachment should be updated as well.
We have used the patched version of eclipse and idea task that always put the source jar reference in its place, and have found no adverse effects nor on IDEA 7 nor Eclipse 3.3 or 3.4. So it seems safe to add the source jar reference by, and if the jar ends up in there somehow, the IDE will pick it up.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638857#action_12638857 ]
lacton commented on BUILDR-165:
-------------------------------
Do you mean that when generating the IDE metadata files, buildr should always try to download the relevant sources and attach a reference to them?
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642647#action_12642647 ]
Timo Rantalaiho commented on BUILDR-165:
----------------------------------------
Lacton,
The essential code (without specs) is in the original issue
by Marko. We're using it with IDEA 7 and it's working
perfectly as far as I can tell.
If you or somebody else gets motivated to add it in the
trunk, I'll be more than happy to test it with IDEA 7 and 8.
And thanks for your work!
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638891#action_12638891 ]
Timo Rantalaiho commented on BUILDR-165:
----------------------------------------
Also, the basic functionality is already in the patch of BUILDR-156 .
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638870#action_12638870 ]
lacton commented on BUILDR-165:
-------------------------------
For Eclipse, I should be able to do it quickly, since we already have specs for the eclipse task.
I'll start working on it.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642824#action_12642824 ]
lacton commented on BUILDR-165:
-------------------------------
Timo,
I applied the IDEA-relevant parts of the patch provided by Marko.
I would be grateful to have your feedback for IDEA 7 and 8.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638865#action_12638865 ]
Marko Sibakov commented on BUILDR-165:
--------------------------------------
i'm quite busy right now but trying to send patch for this issue as soon as possible.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton reassigned BUILDR-165:
-----------------------------
Assignee: (was: lacton)
Anyone motivated for the IDEA part?
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton resolved BUILDR-165.
---------------------------
Resolution: Fixed
Assignee: lacton
I used BUILDR-156 patch for IDEA.
I used TDD for Eclipse.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642845#action_12642845 ]
Timo Rantalaiho commented on BUILDR-165:
----------------------------------------
Great! I'll test it in the upcoming days. Let's hope that the instructions for building from trunk
http://incubator.apache.org/buildr/contributing.html#working_with_source_code
are up-to-date. rake setup seems to take a while to get necessary dependency updates on my home machine.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton updated BUILDR-165:
--------------------------
Comment: was deleted
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638864#action_12638864 ]
Marko Sibakov commented on BUILDR-165:
--------------------------------------
yeah,
We should add source code attachment reference to Eclipse .classpath and IDEA .iml like this:
Eclipse .classpath
<classpathentry kind="var" path="M2_REPO/org/apache/wicket/wicket/1.3.4/wicket-1.3.4.jar" sourcepath="M2_REPO/org/apache/wicket/wicket/1.3.4/wicket-1.3.4-sources.jar"/>
IDEA .iml
<library>
<CLASSES>
<root url="jar://$M2_REPO$/org/apache/wicket/wicket/1.3.4/wicket-1.3.4.jar!/" />
</CLASSES>
<JAVADOC />
<SOURCES>
<root url="jar://$M2_REPO$/org/apache/wicket/wicket/1.3.4/wicket-1.3.4-sources.jar!/" />
</SOURCES>
</library>
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-165) possibility to add source code
attachment references to Eclipse .classpath and IDEA .iml files
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645297#action_12645297 ]
lacton commented on BUILDR-165:
-------------------------------
Timo,
Thank you for your feed back about the patch.
> possibility to add source code attachment references to Eclipse .classpath and IDEA .iml files
> ----------------------------------------------------------------------------------------------
>
> Key: BUILDR-165
> URL: https://issues.apache.org/jira/browse/BUILDR-165
> Project: Buildr
> Issue Type: Improvement
> Components: IDE
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.