You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Francke (JIRA)" <ji...@apache.org> on 2010/09/14 22:14:34 UTC
[jira] Created: (HBASE-2996) Fix and clean up Maven
Fix and clean up Maven
----------------------
Key: HBASE-2996
URL: https://issues.apache.org/jira/browse/HBASE-2996
Project: HBase
Issue Type: Umbrella
Components: build
Reporter: Lars Francke
Assignee: Lars Francke
Fix For: 0.90.0
I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917417#action_12917417 ]
stack commented on HBASE-2996:
------------------------------
Lars, I get this when I apply it:
{code}
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
/Users/stack/checkouts/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java:[58,40] cannot find symbol
symbol : class NamingThreadFactory
location: package com.google.common.util.concurrent
{code}
Do you get the above? Odd since I see the guava dependency in there, even in your new pom.xml
Otherwise patch looks great.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925584#action_12925584 ]
Lars Francke commented on HBASE-2996:
-------------------------------------
No, sorry that's my fault. That part doesn't work on Windows so I commented it out and seem to have forgotten about it. I'll open a new ticket with a trivial patch for this tomorrow if no one has done so until then.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2996) Fix and clean up Maven
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-2996:
--------------------------------
Attachment: HBASE2996.1.patch
This is incomplete. Don't apply yet. Just to show what I've been working on. Input always appreciated.
* Inheriting from Apache parent pom
* Removed the hbase.version property (project.version can be used instead) as this can lead to problems and is not needed
* Removed stuff now inherited: licenses, organization, a few plugin versions etc.
* Fixed links to JIRA and Hudson
* Removed the facebook mirror (that belongs in the settings.xml if it is a complete mirror) and google code repository
* Added missing version properties, ordered properties and dependencies
* Removed dependencyManagement section and moved stuff to the dependencies section
* Updated a few versions:
** mockito: 1.8.4 -> 1.8.5
** guava: r05 -> r06
** jetty: 6.1.24 -> 6.1.25
** jersey: 1.1.5.1 -> 1.4 (this one is to make a dependency issue with avro easier but I couldn't find anything about backwards compatibility)
** jruby: 1.4.0 -> 1.5.2 (supposed to be backwards compatible)
** log4j: 1.2.15 -> 1.2.16
* Added commons-codec as an explicit dependency
* Removed a couple of duplicates with different groupIds (servlet-api, jsp-api, stax-api) and added a detailed note about it
* Added and removed a few exclusions
* Avro 1.4.0 has been released and it should be safe to upgrade but it is not yet on the central maven repositories
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909444#action_12909444 ]
stack commented on HBASE-2996:
------------------------------
One lump patch should be fine Lars. All the above looks good.
Hey, I can't figure a way to display our 'book' inside an html frame so we keep the header and margins. Here is currently what it looks like when you browse to it http://hbase.apache.org/docs/r0.89.20100726/book.html from here, http://hbase.apache.org/docs/r0.89.20100726/
Don't spend time on it if you don't have an idea -- I've already spent a bunch of time on it and currently am of the opinion that its not possible -- thats ok if that is the case.... would just be an nice to have.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917419#action_12917419 ]
stack commented on HBASE-2996:
------------------------------
oh, nm... I see that HLogSplitter should be updated to not use NamingThreadFactory.... let me do that and include in this commit. Thanks Lars.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925551#action_12925551 ]
Jonathan Gray commented on HBASE-2996:
--------------------------------------
This patch seems to have commented out the usage of saveVersion.sh:
{noformat}
<!--<exec executable="sh">
<arg line="${basedir}/src/saveVersion.sh ${project.version} ${generated.sources}"/>
</exec>-->
{noformat}
This is making it so we don't set the hbase version / svn info / etc when packaging so the web ui shows up with Unknown now on trunk.
Was there a reason for commenting this out?
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917679#action_12917679 ]
stack commented on HBASE-2996:
------------------------------
Oh, one thing we seem to have lost was suppression of reams of this stuff Lars:
{code}
2010-10-04 10:48:45,546 WARN [main] hbase.HBaseConfiguration(44): instantiating HBaseConfiguration() is deprecated. Please use HBaseConfiguration#create() to construct a plain Configuration
{code}
Do you remember how that was done? You or Paul figured it IIRC.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2996:
-------------------------
Attachment: 2996-v2.txt
This is what I committed.
Can we close any of the related issues Lars?
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925601#action_12925601 ]
Jonathan Gray commented on HBASE-2996:
--------------------------------------
Don't bother. I'll just remove the commenting out of that line and commit it under this jira. Just wanted to check with you first. Thanks Lars.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917922#action_12917922 ]
Lars Francke commented on HBASE-2996:
-------------------------------------
Sorry, I have no idea. Those messages are correctly captured in the *-output.txt files from the tests and I don't know where these come from. I'll try to find the cause but Paul or KayKay found the solution before.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917674#action_12917674 ]
stack commented on HBASE-2996:
------------------------------
Thanks for doing the closings Lars. FYI, build changes fall into the bug-fix/documentation category in that they can go in after Wednesday so don't worry about hitting deadline for these.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917480#action_12917480 ]
Lars Francke commented on HBASE-2996:
-------------------------------------
Great! Thanks - I'll do the other things I had in mind in another ticket.
HBASE-2982, HBASE-2394 and I think HBASE-2538 should be fixed by this.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2996) Fix and clean up Maven
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-2996.
--------------------------
Hadoop Flags: [Reviewed]
Resolution: Fixed
Committed. Thanks for the patch Lars. I edited src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java. It seems like it was just importing a file from guava that had been removed but it actually wasn't being used -- HLogSplitter had already been updated. As part of the commit I changed a few places where we were still doing 'new HBaseConfiguration' in examples and in package-info.hmtl to instead do 'HBaseConfiguration.create()'.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2996) Fix and clean up Maven
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917485#action_12917485 ]
Lars Francke commented on HBASE-2996:
-------------------------------------
I've closed all the tickets. I don't know if you need to add something to CHANGES.txt. HBASE-2325 needs input from Todd but I believe it can be closed as well. I didn't have time to work on the assembly (HBASE-2548) but I'll try until Wednesday.
And stack sorry I totally forgot about the Docbook issue but I don't have any ideas either at the moment.
> Fix and clean up Maven
> ----------------------
>
> Key: HBASE-2996
> URL: https://issues.apache.org/jira/browse/HBASE-2996
> Project: HBase
> Issue Type: Umbrella
> Components: build
> Reporter: Lars Francke
> Assignee: Lars Francke
> Fix For: 0.90.0
>
> Attachments: 2996-v2.txt, HBASE2996.1.patch
>
>
> I have some changes to the pom.xml that are already covered by a few other issues which I'd like to do in one big patch (because that's the way I started it). I can always split that up in smaller parts if needed.
> I'll upload a unfinished patch just so you know what I've been working on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.