[GitHub] mrunalinikankariya commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

[GitBox <gi...@apache.org>]

mrunalinikankariya commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158220726
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##########
 @@ -98,28 +98,31 @@
     @Override
     public boolean execute(VmwareHostService hostService, CreateEntityDownloadURLCommand cmd) {
         DataTO data = cmd.getData();
+        int timeout = NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()), VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   This part of the code is executed at SSVM where we can not read the DB. So the value read from ConfigKey is set in context and here it isread from context. If the value in the context is null then a default value is read as constant value of DEFAULT_VM_OVA_PACKAGE_TIMEOUT..
   
   I do not understand what is expected when you say use the value dynamically. Do you mean read the value from DB? but DB which could not be accesses from systemvm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services