You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2026/10/21 03:59:00 UTC

[jira] [Commented] (HBASE-30440) Skip archived master-local WALs in WALInputFormat

    [ https://issues.apache.org/jira/browse/HBASE-30440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129416#comment-18129416 ] 

Hudson commented on HBASE-30440:
--------------------------------

Results for branch branch-2.6
	[build #175 on builds.a.o|https://ci-hbase.apache.org/job/HBase-Integration-Test/job/branch-2.6/175/]: (/) *{color:green}+1 overall{color}*
----
details (if available):



(/) {color:green}+1 client integration test for 2.10.2 {color}


(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.5 with shaded hadoop client{color}


(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.3.6 with shaded hadoop client{color}


(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.0 with shaded hadoop client{color}


(/) {color:green}+1 client integration test for 3.4.1 {color}
(/) {color:green}+1 client integration test for 3.4.1 with shaded hadoop client{color}


(/) {color:green}+1 client integration test for 3.4.2 {color}
(/) {color:green}+1 client integration test for 3.4.2 with shaded hadoop client{color}


(/) {color:green}+1 client integration test for 3.4.3 {color}
(/) {color:green}+1 client integration test for 3.4.3 with shaded hadoop client{color}


> Skip archived master-local WALs in WALInputFormat
> -------------------------------------------------
>
>                 Key: HBASE-30440
>                 URL: https://issues.apache.org/jira/browse/HBASE-30440
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Junegunn Choi
>            Assignee: Junegunn Choi
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8, 2.5.17
>
>
> h2. Problem
> When WALPlayer scans {{oldWALs}}, {{WALInputFormat}} creates input splits for archived master-local WALs ending in {{$masterlocalwal$}}. These files contain internal {{master:store}} edits and are not needed for table replay. Actual {{hbase:meta}} edits use separate {{.meta}} WALs.
> {{WALInputFormat.addFile}} treats these filenames as having no parseable timestamp and includes them regardless of the requested time range. Selecting a table only filters edits in the mapper, after the input files have been opened.
> In one of our test clusters, there were 683 master-local WALs among 777 regular WAL files.
> h2. Fix
> Skip files ending in {{MasterRegionFactory.ARCHIVED_WAL_SUFFIX}} before creating input splits. Preserve ordinary WALs, {{.meta}} WALs, and recovered edits. HBASE-26300 already excludes archived master-local WALs from incremental backups.
> Regression coverage checks recursive directory and explicit-file inputs, empty and non-empty master-local WALs, and both settings of {{wal.input.ignore.empty.files}}. All 10 tests in {{TestWALInputFormat}} and {{TestWALRecordReader}} pass. Spotless also passes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)