You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2018/08/17 10:41:31 UTC

[GitHub] spark pull request #22132: [SPARK-25142][PYSPARK] Add error messages when Py...

GitHub user ueshin opened a pull request:

    https://github.com/apache/spark/pull/22132

    [SPARK-25142][PYSPARK] Add error messages when Python worker could not open socket in `_load_from_socket`.

    ## What changes were proposed in this pull request?
    
    Sometimes Python worker can't open socket in `_load_from_socket` for some reason, but it's difficult to figure out the reason because the exception doesn't even contain the messages from `socket.error`s.
    We should at least add the error messages when raising the exception.
    
    ## How was this patch tested?
    
    Manually in my local environment.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ueshin/apache-spark issues/SPARK-25142/socket_error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22132
    
----
commit 16b4f72a3f15c1f5b84b33dcdb4cb8ec980f6bb5
Author: Takuya UESHIN <ue...@...>
Date:   2018-08-17T09:59:28Z

    Add error messages when Python worker could not open socket in `_load_from_socket`.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by ueshin <gi...@git.apache.org>.

Github user ueshin commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    cc @HyukjinKwon 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2269/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94884/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    **[Test build #94884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94884/testReport)** for PR 22132 at commit [`16b4f72`](https://github.com/apache/spark/commit/16b4f72a3f15c1f5b84b33dcdb4cb8ec980f6bb5).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22132: [SPARK-25142][PYSPARK] Add error messages when Python wo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22132
  
    **[Test build #94884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94884/testReport)** for PR 22132 at commit [`16b4f72`](https://github.com/apache/spark/commit/16b4f72a3f15c1f5b84b33dcdb4cb8ec980f6bb5).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org