You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by fo...@apache.org on 2022/06/28 22:13:38 UTC
[hudi] branch master updated: [HUDI-4334] close SparkRDDWriteClient after usage in Create/Delete/RollbackSavepointsProcedure (#5994)
This is an automated email from the ASF dual-hosted git repository.
forwardxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new e3eb14ad2d [HUDI-4334] close SparkRDDWriteClient after usage in Create/Delete/RollbackSavepointsProcedure (#5994)
e3eb14ad2d is described below
commit e3eb14ad2d5bd25fcfd6bb2eb6e991558c0684ed
Author: Teng <te...@outlook.com>
AuthorDate: Wed Jun 29 06:13:29 2022 +0800
[HUDI-4334] close SparkRDDWriteClient after usage in Create/Delete/RollbackSavepointsProcedure (#5994)
---
.../spark/sql/hudi/command/procedures/CreateSavepointsProcedure.scala | 2 ++
.../spark/sql/hudi/command/procedures/DeleteSavepointsProcedure.scala | 2 ++
.../spark/sql/hudi/command/procedures/RollbackSavepointsProcedure.scala | 2 ++
3 files changed, 6 insertions(+)
diff --git a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/CreateSavepointsProcedure.scala b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/CreateSavepointsProcedure.scala
index ed4905ed04..43098d1e98 100644
--- a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/CreateSavepointsProcedure.scala
+++ b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/CreateSavepointsProcedure.scala
@@ -68,6 +68,8 @@ class CreateSavepointsProcedure extends BaseProcedure with ProcedureBuilder with
} catch {
case _: HoodieSavepointException =>
logWarning(s"Failed: Could not create savepoint $commitTime.")
+ } finally {
+ client.close()
}
Seq(Row(result))
diff --git a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/DeleteSavepointsProcedure.scala b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/DeleteSavepointsProcedure.scala
index 11416ac22c..fcef175ebd 100644
--- a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/DeleteSavepointsProcedure.scala
+++ b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/DeleteSavepointsProcedure.scala
@@ -67,6 +67,8 @@ class DeleteSavepointsProcedure extends BaseProcedure with ProcedureBuilder with
} catch {
case _: HoodieSavepointException =>
logWarning(s"Failed: Could not delete savepoint $instantTime.")
+ } finally {
+ client.close()
}
Seq(Row(result))
diff --git a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RollbackSavepointsProcedure.scala b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RollbackSavepointsProcedure.scala
index a11e614176..fa8f33d306 100644
--- a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RollbackSavepointsProcedure.scala
+++ b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RollbackSavepointsProcedure.scala
@@ -67,6 +67,8 @@ class RollbackSavepointsProcedure extends BaseProcedure with ProcedureBuilder wi
} catch {
case _: HoodieSavepointException =>
logWarning(s"The commit $instantTime failed to roll back.")
+ } finally {
+ client.close()
}
Seq(Row(result))