[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

[GitBox <gi...@apache.org>]

bgeng777 commented on code in PR #242:
URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881193025


##########
docs/content/docs/operations/helm.md:
##########
@@ -107,6 +107,28 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr
 The operator supports watching a specific list of namespaces for FlinkDeployment resources. You can enable it by setting the `--set watchNamespaces={flink-test}` parameter.
 When this is enabled role-based access control is only created specifically for these namespaces for the operator and the jobmanagers, otherwise it defaults to cluster scope.
 
+Note, when working with webhook in a specified namespace, users should pay attention to the definition of `namespaceSelector.matchExpressions` in `webhook.yaml`. Currently, the default implementation of webhook relies on the `kubernetes.io/metadata.name` label to filter the validation requests

Review Comment:
   It does look nicer:
   <img width="842" alt="image" src="https://user-images.githubusercontent.com/80749729/170175942-a412af6f-e2b6-4ddf-adf8-2283984fedd0.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org