You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2015/05/15 15:08:00 UTC
Starting work on 2.5
Finally struts-archive was migrated to Git [1] so I can kicking out
deprecated plugins and start cleaning up the code [2]
[1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
[2] https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
2015-05-15 23:07 GMT+02:00 Aaron Johnson <jo...@gmail.com>:
> I would suggest dropping support for the embedded JSP plugin. The ability
> to serve JSPs (or any classpath resource) from a JAR is a part of the
> servlet specification since 3.0.
Nice idea but not everybody can switch to 3.0 - so I have added your
suggestion to plan for Struts 3.0 :)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Aaron Johnson <jo...@gmail.com>.
I would suggest dropping support for the embedded JSP plugin. The ability
to serve JSPs (or any classpath resource) from a JAR is a part of the
servlet specification since 3.0.
On Fri, May 15, 2015 at 8:08 AM, Lukasz Lenart <lu...@apache.org>
wrote:
> Finally struts-archive was migrated to Git [1] so I can kicking out
> deprecated plugins and start cleaning up the code [2]
>
> [1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> [2]
> https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Starting work on 2.5
Posted by Johannes Geppert <jo...@apache.org>.
+1 for JDK7
#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
2015-05-26 9:39 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2015-05-26 9:36 GMT+02:00 Greg Huber <gr...@gmail.com>:
> > Been using struts with jdk1.7.0_xx for ages and no issues.
>
> Thanks Greg! Just wondering if someone is using JDK6 these days? :)
> JDK7 is out of business now so maybe it's a good idea to support the
> last out-of-public-updates version which means JDK7
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
2015-05-26 9:36 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Been using struts with jdk1.7.0_xx for ages and no issues.
Thanks Greg! Just wondering if someone is using JDK6 these days? :)
JDK7 is out of business now so maybe it's a good idea to support the
last out-of-public-updates version which means JDK7
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Greg Huber <gr...@gmail.com>.
Been using struts with jdk1.7.0_xx for ages and no issues.
... After April 2015, Oracle will no longer post updates of Java SE 7 to
its public download sites.
Cheers Greg
On 25 May 2015 at 10:23, Lukasz Lenart <lu...@apache.org> wrote:
> 2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > Finally struts-archive was migrated to Git [1] so I can kicking out
> > deprecated plugins and start cleaning up the code [2]
> >
> > [1]
> https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> > [2]
> https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
>
> Regarding to the Plan we should switch to JDK7 in Struts 2.5 - just
> wondering if this isn't too early? Maybe we should postpone that move
> till Struts3, wdyt?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
This is official: we're running on JDK7 from now on :) Thanks Aaron!
2015-05-26 17:48 GMT+02:00 Paul Benedict <pb...@apache.org>:
> +1 JDK 7
>
>
> Cheers,
> Paul
>
> On Tue, May 26, 2015 at 8:39 AM, Aaron Johnson <jo...@gmail.com>
> wrote:
>
>> The best place for big changes is early in the release cycle. I haven't had
>> any runtime issues with JDK7 and Struts.
>>
>> On Tue, May 26, 2015 at 3:51 AM, Christoph Nenning <
>> Christoph.Nenning@lex-com.net> wrote:
>>
>> > one more +1 for jdk7
>> >
>> >
>> > regards,
>> > Christoph
>> >
>> > This Email was scanned by Sophos Anti Virus
>> >
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Paul Benedict <pb...@apache.org>.
+1 JDK 7
Cheers,
Paul
On Tue, May 26, 2015 at 8:39 AM, Aaron Johnson <jo...@gmail.com>
wrote:
> The best place for big changes is early in the release cycle. I haven't had
> any runtime issues with JDK7 and Struts.
>
> On Tue, May 26, 2015 at 3:51 AM, Christoph Nenning <
> Christoph.Nenning@lex-com.net> wrote:
>
> > one more +1 for jdk7
> >
> >
> > regards,
> > Christoph
> >
> > This Email was scanned by Sophos Anti Virus
> >
>
Re: Starting work on 2.5
Posted by Aaron Johnson <jo...@gmail.com>.
The best place for big changes is early in the release cycle. I haven't had
any runtime issues with JDK7 and Struts.
On Tue, May 26, 2015 at 3:51 AM, Christoph Nenning <
Christoph.Nenning@lex-com.net> wrote:
> one more +1 for jdk7
>
>
> regards,
> Christoph
>
> This Email was scanned by Sophos Anti Virus
>
Re: Starting work on 2.5
Posted by Christoph Nenning <Ch...@lex-com.net>.
one more +1 for jdk7
regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> Finally struts-archive was migrated to Git [1] so I can kicking out
> deprecated plugins and start cleaning up the code [2]
>
> [1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> [2] https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
Regarding to the Plan we should switch to JDK7 in Struts 2.5 - just
wondering if this isn't too early? Maybe we should postpone that move
till Struts3, wdyt?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Dave Newton <da...@gmail.com>.
Yeah, that's probably a good plan.
On May 17, 2015 4:34 AM, "Lukasz Lenart" <lu...@apache.org> wrote:
> 2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > Finally struts-archive was migrated to Git [1] so I can kicking out
> > deprecated plugins and start cleaning up the code [2]
> >
> > [1]
> https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> > [2]
> https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
>
> Before I will start working on 2.5 I would like throw away GitFlow -
> it simple doesn't work for the project, to point just few issues:
> - dedicated develop and bunch of feature branches which are replicated
> all over the world and scatter other's repos [1]
> - Maven does tagging which means I always have to remember to use -n
> flag to avoid tagging by GitFlow
> - Maven introduces next development cycle which means I always must
> manually update version in master branch and resolve bunch of
> conflicts in poms
> - etc
>
> My idea is to have only master branch in Apache Git and use GitHub for
> large work, so committers can always directly push changes to master
> (we use tags to keep track on versions). If you are going to work on
> something bigger you can create local branch or clone Struts via GH
> and work on your own clone there. Next you can prepare a PR which will
> be directly merged into master. So Git repo will always contain just
> one branch which will reduce number of branches scattered over the
> world. And as we use Maven to release new versions, it will be
> possible to release directly from master branch - no need to update
> versions and resolve conflicts.
>
> All this is based on my over year of experience with using GitFlow in
> Struts. If there be no objections, in 72h - assuming silence
> consensus, I will drop GitFlow support.
>
>
> [1] my local list of branches
> * develop
> feature/WW-4176-support-string-keys-in-json
> feature/locale-aware-converters
> master
> remotes/aleksandr-m/develop
> remotes/aleksandr-m/feature/exclude-object-class
> remotes/aleksandr-m/feature/http-interceptor
> remotes/aleksandr-m/feature/preselect-optgroup
> remotes/aleksandr-m/feature/remove-html5-deprecations
> remotes/aleksandr-m/feature/use-js-to-support-multiple-buttons
> remotes/aleksandr-m/feature/visitor-validator-full-field-name
> remotes/aleksandr-m/master
> remotes/origin/HEAD -> origin/master
> remotes/origin/develop
> remotes/origin/feature/locale-aware-converters
> remotes/origin/master
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
Starting with the master plan - please do not touch Git :)
2015-05-17 10:33 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>> Finally struts-archive was migrated to Git [1] so I can kicking out
>> deprecated plugins and start cleaning up the code [2]
>>
>> [1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
>> [2] https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
>
> Before I will start working on 2.5 I would like throw away GitFlow -
> it simple doesn't work for the project, to point just few issues:
> - dedicated develop and bunch of feature branches which are replicated
> all over the world and scatter other's repos [1]
> - Maven does tagging which means I always have to remember to use -n
> flag to avoid tagging by GitFlow
> - Maven introduces next development cycle which means I always must
> manually update version in master branch and resolve bunch of
> conflicts in poms
> - etc
>
> My idea is to have only master branch in Apache Git and use GitHub for
> large work, so committers can always directly push changes to master
> (we use tags to keep track on versions). If you are going to work on
> something bigger you can create local branch or clone Struts via GH
> and work on your own clone there. Next you can prepare a PR which will
> be directly merged into master. So Git repo will always contain just
> one branch which will reduce number of branches scattered over the
> world. And as we use Maven to release new versions, it will be
> possible to release directly from master branch - no need to update
> versions and resolve conflicts.
>
> All this is based on my over year of experience with using GitFlow in
> Struts. If there be no objections, in 72h - assuming silence
> consensus, I will drop GitFlow support.
>
>
> [1] my local list of branches
> * develop
> feature/WW-4176-support-string-keys-in-json
> feature/locale-aware-converters
> master
> remotes/aleksandr-m/develop
> remotes/aleksandr-m/feature/exclude-object-class
> remotes/aleksandr-m/feature/http-interceptor
> remotes/aleksandr-m/feature/preselect-optgroup
> remotes/aleksandr-m/feature/remove-html5-deprecations
> remotes/aleksandr-m/feature/use-js-to-support-multiple-buttons
> remotes/aleksandr-m/feature/visitor-validator-full-field-name
> remotes/aleksandr-m/master
> remotes/origin/HEAD -> origin/master
> remotes/origin/develop
> remotes/origin/feature/locale-aware-converters
> remotes/origin/master
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Rene Gielen <gi...@it-neering.net>.
Ah, fine then. I was under the impression that only recently deprecated
plugins would be found in
https://github.com/apache/struts-archive/tree/master/plugins.
Thanks folks for clearing up my confusion :)
- René
Am 22.05.15 um 15:51 schrieb Johannes Geppert:
>> It was already there, I assumed it was you when you were working on
>> adding support for Portlet 2 spec
>
> Right! This is the old one which was replaced with the new portlet2 spec
> implementation.
>
>
> #################################################
> web: http://www.jgeppert.com
> twitter: http://twitter.com/jogep
>
>
> 2015-05-22 15:46 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>
>> 2015-05-22 13:40 GMT+02:00 Rene Gielen <gi...@it-neering.net>:
>>> While it is OK for me to drop GitFlow, I'm -1 for moving core
>>> development to GitHub. We should not rely on an external service for our
>>> internal workflow. GitHub should remain the interface for external
>>> contributors, but not the place where the committership driven
>>> development should take place. I'm pretty sure we'll get in trouble
>>> justifying such a move towards the board.
>>
>> I'm not saying that we must use GH for everything, but instead
>> scattering people's repos I prefer working on my own clone or local
>> branch. Each branch pushed into Apache Git will be replicated to
>> GitHub and then to users' repos.
>>
>>> Basides that, what was the reasoning behind deprecating
>>> struts2-portlet-plugin? Did I miss something?
>>
>> It was already there, I assumed it was you when you were working on
>> adding support for Portlet 2 spec
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Johannes Geppert <jo...@apache.org>.
> It was already there, I assumed it was you when you were working on
> adding support for Portlet 2 spec
Right! This is the old one which was replaced with the new portlet2 spec
implementation.
#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
2015-05-22 15:46 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2015-05-22 13:40 GMT+02:00 Rene Gielen <gi...@it-neering.net>:
> > While it is OK for me to drop GitFlow, I'm -1 for moving core
> > development to GitHub. We should not rely on an external service for our
> > internal workflow. GitHub should remain the interface for external
> > contributors, but not the place where the committership driven
> > development should take place. I'm pretty sure we'll get in trouble
> > justifying such a move towards the board.
>
> I'm not saying that we must use GH for everything, but instead
> scattering people's repos I prefer working on my own clone or local
> branch. Each branch pushed into Apache Git will be replicated to
> GitHub and then to users' repos.
>
> > Basides that, what was the reasoning behind deprecating
> > struts2-portlet-plugin? Did I miss something?
>
> It was already there, I assumed it was you when you were working on
> adding support for Portlet 2 spec
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
2015-05-22 13:40 GMT+02:00 Rene Gielen <gi...@it-neering.net>:
> While it is OK for me to drop GitFlow, I'm -1 for moving core
> development to GitHub. We should not rely on an external service for our
> internal workflow. GitHub should remain the interface for external
> contributors, but not the place where the committership driven
> development should take place. I'm pretty sure we'll get in trouble
> justifying such a move towards the board.
I'm not saying that we must use GH for everything, but instead
scattering people's repos I prefer working on my own clone or local
branch. Each branch pushed into Apache Git will be replicated to
GitHub and then to users' repos.
> Basides that, what was the reasoning behind deprecating
> struts2-portlet-plugin? Did I miss something?
It was already there, I assumed it was you when you were working on
adding support for Portlet 2 spec
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Rene Gielen <gi...@it-neering.net>.
While it is OK for me to drop GitFlow, I'm -1 for moving core
development to GitHub. We should not rely on an external service for our
internal workflow. GitHub should remain the interface for external
contributors, but not the place where the committership driven
development should take place. I'm pretty sure we'll get in trouble
justifying such a move towards the board.
Basides that, what was the reasoning behind deprecating
struts2-portlet-plugin? Did I miss something?
- René
Am 17.05.15 um 10:33 schrieb Lukasz Lenart:
> 2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>> Finally struts-archive was migrated to Git [1] so I can kicking out
>> deprecated plugins and start cleaning up the code [2]
>>
>> [1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
>> [2] https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
>
> Before I will start working on 2.5 I would like throw away GitFlow -
> it simple doesn't work for the project, to point just few issues:
> - dedicated develop and bunch of feature branches which are replicated
> all over the world and scatter other's repos [1]
> - Maven does tagging which means I always have to remember to use -n
> flag to avoid tagging by GitFlow
> - Maven introduces next development cycle which means I always must
> manually update version in master branch and resolve bunch of
> conflicts in poms
> - etc
>
> My idea is to have only master branch in Apache Git and use GitHub for
> large work, so committers can always directly push changes to master
> (we use tags to keep track on versions). If you are going to work on
> something bigger you can create local branch or clone Struts via GH
> and work on your own clone there. Next you can prepare a PR which will
> be directly merged into master. So Git repo will always contain just
> one branch which will reduce number of branches scattered over the
> world. And as we use Maven to release new versions, it will be
> possible to release directly from master branch - no need to update
> versions and resolve conflicts.
>
> All this is based on my over year of experience with using GitFlow in
> Struts. If there be no objections, in 72h - assuming silence
> consensus, I will drop GitFlow support.
>
>
> [1] my local list of branches
> * develop
> feature/WW-4176-support-string-keys-in-json
> feature/locale-aware-converters
> master
> remotes/aleksandr-m/develop
> remotes/aleksandr-m/feature/exclude-object-class
> remotes/aleksandr-m/feature/http-interceptor
> remotes/aleksandr-m/feature/preselect-optgroup
> remotes/aleksandr-m/feature/remove-html5-deprecations
> remotes/aleksandr-m/feature/use-js-to-support-multiple-buttons
> remotes/aleksandr-m/feature/visitor-validator-full-field-name
> remotes/aleksandr-m/master
> remotes/origin/HEAD -> origin/master
> remotes/origin/develop
> remotes/origin/feature/locale-aware-converters
> remotes/origin/master
>
>
> Regards
>
--
René Gielen
IT-Neering.net
Kalkbergstraße 171, 52080 Aachen, Germany
Tel: +49-(0)2405-4067285
Fax: +49-(0)2405-4067286
Cel: +49-(0)163-2844164
http://twitter.com/rgielen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Starting work on 2.5
Posted by Christoph Nenning <Ch...@lex-com.net>.
yes, i also think it is best to use GH for real work
>
> 2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > Finally struts-archive was migrated to Git [1] so I can kicking out
> > deprecated plugins and start cleaning up the code [2]
> >
> > [1]
https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> > [2] https://cwiki.apache.org/confluence/display/WW/Struts
> +Next#StrutsNext-M1(akaStruts2.5)
>
> Before I will start working on 2.5 I would like throw away GitFlow -
> it simple doesn't work for the project, to point just few issues:
> - dedicated develop and bunch of feature branches which are replicated
> all over the world and scatter other's repos [1]
> - Maven does tagging which means I always have to remember to use -n
> flag to avoid tagging by GitFlow
> - Maven introduces next development cycle which means I always must
> manually update version in master branch and resolve bunch of
> conflicts in poms
> - etc
>
> My idea is to have only master branch in Apache Git and use GitHub for
> large work, so committers can always directly push changes to master
> (we use tags to keep track on versions). If you are going to work on
> something bigger you can create local branch or clone Struts via GH
> and work on your own clone there. Next you can prepare a PR which will
> be directly merged into master. So Git repo will always contain just
> one branch which will reduce number of branches scattered over the
> world. And as we use Maven to release new versions, it will be
> possible to release directly from master branch - no need to update
> versions and resolve conflicts.
>
> All this is based on my over year of experience with using GitFlow in
> Struts. If there be no objections, in 72h - assuming silence
> consensus, I will drop GitFlow support.
>
>
> [1] my local list of branches
> * develop
> feature/WW-4176-support-string-keys-in-json
> feature/locale-aware-converters
> master
> remotes/aleksandr-m/develop
> remotes/aleksandr-m/feature/exclude-object-class
> remotes/aleksandr-m/feature/http-interceptor
> remotes/aleksandr-m/feature/preselect-optgroup
> remotes/aleksandr-m/feature/remove-html5-deprecations
> remotes/aleksandr-m/feature/use-js-to-support-multiple-buttons
> remotes/aleksandr-m/feature/visitor-validator-full-field-name
> remotes/aleksandr-m/master
> remotes/origin/HEAD -> origin/master
> remotes/origin/develop
> remotes/origin/feature/locale-aware-converters
> remotes/origin/master
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
This Email was scanned by Sophos Anti Virus
Re: Starting work on 2.5
Posted by Lukasz Lenart <lu...@apache.org>.
2015-05-15 15:08 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> Finally struts-archive was migrated to Git [1] so I can kicking out
> deprecated plugins and start cleaning up the code [2]
>
> [1] https://git1-us-west.apache.org/repos/asf?p=struts-archive.git;a=tree
> [2] https://cwiki.apache.org/confluence/display/WW/Struts+Next#StrutsNext-M1(akaStruts2.5)
Before I will start working on 2.5 I would like throw away GitFlow -
it simple doesn't work for the project, to point just few issues:
- dedicated develop and bunch of feature branches which are replicated
all over the world and scatter other's repos [1]
- Maven does tagging which means I always have to remember to use -n
flag to avoid tagging by GitFlow
- Maven introduces next development cycle which means I always must
manually update version in master branch and resolve bunch of
conflicts in poms
- etc
My idea is to have only master branch in Apache Git and use GitHub for
large work, so committers can always directly push changes to master
(we use tags to keep track on versions). If you are going to work on
something bigger you can create local branch or clone Struts via GH
and work on your own clone there. Next you can prepare a PR which will
be directly merged into master. So Git repo will always contain just
one branch which will reduce number of branches scattered over the
world. And as we use Maven to release new versions, it will be
possible to release directly from master branch - no need to update
versions and resolve conflicts.
All this is based on my over year of experience with using GitFlow in
Struts. If there be no objections, in 72h - assuming silence
consensus, I will drop GitFlow support.
[1] my local list of branches
* develop
feature/WW-4176-support-string-keys-in-json
feature/locale-aware-converters
master
remotes/aleksandr-m/develop
remotes/aleksandr-m/feature/exclude-object-class
remotes/aleksandr-m/feature/http-interceptor
remotes/aleksandr-m/feature/preselect-optgroup
remotes/aleksandr-m/feature/remove-html5-deprecations
remotes/aleksandr-m/feature/use-js-to-support-multiple-buttons
remotes/aleksandr-m/feature/visitor-validator-full-field-name
remotes/aleksandr-m/master
remotes/origin/HEAD -> origin/master
remotes/origin/develop
remotes/origin/feature/locale-aware-converters
remotes/origin/master
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org