You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 13:46:17 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3993: add support for xz file compression and `compression` feature

alamb commented on code in PR #3993:
URL: https://github.com/apache/arrow-datafusion/pull/3993#discussion_r1010447874


##########
datafusion/core/Cargo.toml:
##########
@@ -47,6 +47,7 @@ force_hash_collisions = []
 # Used to enable JIT code generation
 jit = ["datafusion-jit", "datafusion-row/jit"]
 pyarrow = ["pyo3", "arrow/pyarrow", "datafusion-common/pyarrow"]
+compression = ["xz2", "bzip2", "flate2", "async-compression"]

Review Comment:
   I wonder how this is tested? 
   
   The default features do not include compression
   
   > default = ["crypto_expressions", "regex_expressions", "unicode_expressions"]
   
   So that would imply to me we would need a change in `.github` to run a test with the feature flag... But I don't see any tests that fail 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org