You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/08 21:00:20 UTC
[GitHub] codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix
editing Variable with empty key crashing
codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing
URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-408263467
# [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=h1) Report
> Merging [#3648](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/8b04e20709ebeb41aeefc0c5e3f12d35108ea504?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `86.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/3648/graphs/tree.svg?token=WdLKlKHOAU&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
+ Coverage 77.64% 77.64% +<.01%
==========================================
Files 204 204
Lines 15801 15825 +24
==========================================
+ Hits 12268 12287 +19
- Misses 3533 3538 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www\_rbac/utils.py](https://codecov.io/gh/apache/incubator-airflow/pull/3648/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy91dGlscy5weQ==) | `67.1% <100%> (+0.88%)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/incubator-airflow/pull/3648/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `69.04% <100%> (+0.15%)` | :arrow_up: |
| [airflow/www/utils.py](https://codecov.io/gh/apache/incubator-airflow/pull/3648/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdXRpbHMucHk=) | `88.81% <100%> (+0.28%)` | :arrow_up: |
| [airflow/www\_rbac/views.py](https://codecov.io/gh/apache/incubator-airflow/pull/3648/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy92aWV3cy5weQ==) | `72.72% <60%> (-0.14%)` | :arrow_down: |
| [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3648/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=) | `88.78% <0%> (-0.05%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=footer). Last update [8b04e20...e8669f1](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services