[PR] IMAP: Add overwrite option to ImapHook.download_mail_attachments [airflow]

["longhuynh5713 (via GitHub)" <gi...@apache.org>]

longhuynh5713 opened a new pull request, #67019:
URL: https://github.com/apache/airflow/pull/67019

   The current implementation of `download_mail_attachments` in `ImapHook` silently overwrites files if they already exist in the target directory. This can lead to data loss when multiple emails have attachments with the same filename.
   
   This PR adds a configurable `overwrite` parameter (defaulting to `True` for backward compatibility) to `download_mail_attachments`. When set to `False`, the hook will automatically rename files by appending a numeric suffix (e.g., `report (1).csv`) if a collision is detected.
   
   Summary:
   - Added `overwrite` parameter to `download_mail_attachments`.
   - Implemented `_resolve_non_conflicting_path` helper to handle filename collisions.
   - Added comprehensive unit tests for both overwrite and collision-avoidance scenarios.
   - Updated the IMAP provider changelog.
   
   closes: #65870
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — gemini-3-flash-preview
   
   Generated-by: gemini-3-flash-preview following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IMAP: Add overwrite option to ImapHook.download_mail_attachments [airflow]

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on PR #67019:
URL: https://github.com/apache/airflow/pull/67019#issuecomment-4464984969

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IMAP: Add overwrite option to ImapHook.download_mail_attachments [airflow]

["longhuynh5713 (via GitHub)" <gi...@apache.org>]

longhuynh5713 closed pull request #67019: IMAP: Add overwrite option to ImapHook.download_mail_attachments
URL: https://github.com/apache/airflow/pull/67019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org