[jira] [Commented] (KAFKA-6233) Removed unnecessary null check

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258209#comment-16258209 ] 

ASF GitHub Bot commented on KAFKA-6233:
---------------------------------------

GitHub user sagarchavan3172 opened a pull request:

    https://github.com/apache/kafka/pull/4232

    KAFKA-6233 :Removed unnecessary null check

    *More detailed description of your change,
    if necessary. The PR title and PR message become
    the squashed commit message, so use a separate
    comment to ping reviewers.*
    
    *Summary of testing strategy (including rationale)
    for the feature or bug fix. Unit and/or integration
    tests are expected for any behaviour change and
    system tests should be considered for larger changes.*
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sagarchavan3172/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4232
    
----
commit ea843103d6d10775e58be53bb6a02154c0a10735
Author: Sagar Chavan <sa...@gmail.com>
Date:   2017-11-18T20:43:33Z

    Removed unnecessary null check

----


> Removed unnecessary null check
> ------------------------------
>
>                 Key: KAFKA-6233
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6233
>             Project: Kafka
>          Issue Type: New Feature
>          Components: clients
>    Affects Versions: 0.10.1.1, 0.10.2.1, 1.0.0, 0.11.0.2
>            Reporter: sagar sukhadev chavan
>            Priority: Trivial
>
> Removed unnecessary null check
> if (encodingValue != null && encodingValue instanceof String)
> null instanceof String returns false hence replaced the check with
> if (encodingValue instanceof String)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)