You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/11/14 21:14:04 UTC

[GitHub] yush1ga commented on a change in pull request #901: Introduce configuration converter

yush1ga commented on a change in pull request #901: Introduce configuration converter
URL: https://github.com/apache/incubator-pulsar/pull/901#discussion_r150964865
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -1272,4 +1274,28 @@ public void setPreferLaterVersions(boolean preferLaterVersions) {
     public int getWebSocketConnectionsPerBroker() { return webSocketConnectionsPerBroker; }
 
     public void setWebSocketConnectionsPerBroker(int webSocketConnectionsPerBroker) { this.webSocketConnectionsPerBroker = webSocketConnectionsPerBroker; }
+
+    public static ServiceConfiguration convertFrom(PulsarConfiguration conf) throws RuntimeException {
 
 Review comment:
   I moved the utility method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services