[GitHub] pritidesai commented on a change in pull request #784: Adding support for package binding from any namespace and declaring public packages

[GitBox <gi...@apache.org>]

pritidesai commented on a change in pull request #784: Adding support for package binding from any namespace and declaring public packages
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/784#discussion_r173497318
 
 

 ##########
 File path: utils/dependencies.go
 ##########
 @@ -65,7 +70,7 @@ func NewDependencyRecord(projectPath string,
 }
 
 func LocationIsBinding(location string) bool {
-	if strings.HasPrefix(location, "/whisk.system") || strings.HasPrefix(location, "whisk.system") {
+	if strings.HasPrefix(location, "/"+WHISK_SYSTEM) || strings.HasPrefix(location, WHISK_SYSTEM) || strings.HasPrefix(location, "/") {
 
 Review comment:
   doesn't look like `whisk.system` is allowed as is in creating package binding, namespace is always identified with `/`, let me fix this.
   
   ```
   wsk package bind /whisk.system/samples valhallaSamples --param place Valhalla
   ok: created binding valhallaSamples
   wsk action invoke --result valhallaSamples/greeting --param name Odin
   {
       "payload": "Hello, Odin from Valhalla!"
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services