[GitHub] dch commented on issue #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

dch commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-366781960
 
 
   @pierrekilly welcome & nice work on your first PR!
   
   Some background info which may be useful to help you understand what happens next, 
   as your PR requires the project to include a 3rd party library. We already have quite a few
   of these, so it's fine to do this but we need to take a few precautions.
   
   Your tidy changes require a NIF (C code) addition to the CouchDB distribution, so
   we need to make sure of 3 things:
   
   1. that this runs on all our common platforms, from linux, windows and BSDs
   2. the NIF interface doesn't adversely impact the VM's behaviour
   3. that the licensing of that code, and its provenance, meets our standards
   
   The Apache Software Foundation, as policy, releases sources artefact that contains
   *only* ALv2 licensed components, or those that fall under a sufficiently "free"
   licence that we can include it in a release -- there's a pre-approved list https://apache.org/legal/resolved.html#category-a here
   
   @dch is happy to do the IP clearance dance assuming we're OK on the NIF side of things. Can anybody look into that? the NIF is an R13B04 era style, does this need any changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services