You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 12:40:50 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12916: Adds predefined providers to install_requires.

kaxil commented on a change in pull request #12916:
URL: https://github.com/apache/airflow/pull/12916#discussion_r538321436



##########
File path: setup.py
##########
@@ -874,6 +874,22 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
 )
 
 
+class AirflowDistribtuion(Distribution):
+    """setuptools.Distribution subclass with Airflow specific behaviour"""
+
+    # https://github.com/PyCQA/pylint/issues/3737
+    def parse_config_files(self, *args, **kwargs):  # pylint: disable=signature-differs
+        """
+        Ensure that when we have been asked to install providers from sources
+        that we don't *also* try ot install those providers from PyPI

Review comment:
       ```suggestion
           that we don't *also* try to install those providers from PyPI
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org