You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/16 13:02:12 UTC
[GitHub] [incubator-doris] jackwener opened a new pull request, #10199: [feature](nereids): cost and stats.
jackwener opened a new pull request, #10199:
URL: https://github.com/apache/incubator-doris/pull/10199
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10199:
URL: https://github.com/apache/doris/pull/10199#discussion_r900103688
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostCalculator.java:
##########
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.analysis.SlotId;
+import org.apache.doris.nereids.OperatorVisitor;
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalAggregation;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Calculate the cost of a plan.
+ * Inspired by Presto.
+ */
+public class CostCalculator {
+ /**
+ * Constructor.
+ */
+ public double calculateCost(GroupExpression groupExpression) {
+ PlanContext planContext = new PlanContext(groupExpression);
+ CostEstimator costCalculator = new CostEstimator();
+ CostEstimate costEstimate = groupExpression.getOperator()
+ .accept(costCalculator, planContext);
+ return costFormula(costEstimate);
+ }
+
+ private double costFormula(CostEstimate costEstimate) {
+ double cpuCostWeight = 1;
+ double memoryCostWeight = 1;
+ double networkCostWeight = 1;
+ return costEstimate.getCpuCost() * cpuCostWeight + costEstimate.getMemoryCost() * memoryCostWeight
+ + costEstimate.getNetworkCost() * networkCostWeight;
+ }
+
+ private static class CostEstimator extends OperatorVisitor<CostEstimate, PlanContext> {
+ @Override
+ public CostEstimate visitOperator(Operator operator, PlanContext context) {
+ return CostEstimate.zero();
+ }
+
+ @Override
+ public CostEstimate visitPhysicalAggregation(PhysicalAggregation physicalAggregation, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalOlapScan(PhysicalOlapScan physicalOlapScan, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalHashJoin(PhysicalHashJoin physicalHashJoin, PlanContext context) {
+ Preconditions.checkState(context.getGroupExpression().arity() == 2);
+ Preconditions.checkState(context.getChildrenStats().size() == 2);
+
+ StatsDeriveResult leftStatistics = context.getChildStatistics(0);
+ StatsDeriveResult rightStatistics = context.getChildStatistics(1);
+
+ // TODO: handle some case
+
+ List<SlotId> leftIds = context.getChildOutputSlots(0).stream().map(Slot::getId).map(SlotId::create)
Review Comment:
I think `SlotId` is better than `ExprId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10199:
URL: https://github.com/apache/doris/pull/10199#issuecomment-1161906480
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10199:
URL: https://github.com/apache/doris/pull/10199#issuecomment-1161906425
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10199:
URL: https://github.com/apache/doris/pull/10199#discussion_r900106553
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostCalculator.java:
##########
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.analysis.SlotId;
+import org.apache.doris.nereids.OperatorVisitor;
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalAggregation;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Calculate the cost of a plan.
+ * Inspired by Presto.
+ */
+public class CostCalculator {
+ /**
+ * Constructor.
+ */
+ public double calculateCost(GroupExpression groupExpression) {
+ PlanContext planContext = new PlanContext(groupExpression);
+ CostEstimator costCalculator = new CostEstimator();
+ CostEstimate costEstimate = groupExpression.getOperator()
+ .accept(costCalculator, planContext);
+ return costFormula(costEstimate);
+ }
+
+ private double costFormula(CostEstimate costEstimate) {
+ double cpuCostWeight = 1;
+ double memoryCostWeight = 1;
+ double networkCostWeight = 1;
+ return costEstimate.getCpuCost() * cpuCostWeight + costEstimate.getMemoryCost() * memoryCostWeight
+ + costEstimate.getNetworkCost() * networkCostWeight;
+ }
+
+ private static class CostEstimator extends OperatorVisitor<CostEstimate, PlanContext> {
+ @Override
+ public CostEstimate visitOperator(Operator operator, PlanContext context) {
+ return CostEstimate.zero();
+ }
+
+ @Override
+ public CostEstimate visitPhysicalAggregation(PhysicalAggregation physicalAggregation, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalOlapScan(PhysicalOlapScan physicalOlapScan, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalHashJoin(PhysicalHashJoin physicalHashJoin, PlanContext context) {
+ Preconditions.checkState(context.getGroupExpression().arity() == 2);
+ Preconditions.checkState(context.getChildrenStats().size() == 2);
+
+ StatsDeriveResult leftStatistics = context.getChildStatistics(0);
+ StatsDeriveResult rightStatistics = context.getChildStatistics(1);
+
+ // TODO: handle some case
+
+ List<SlotId> leftIds = context.getChildOutputSlots(0).stream().map(Slot::getId).map(SlotId::create)
Review Comment:
as discuss before, we do not use any data structure in old optimizer as far as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10199:
URL: https://github.com/apache/doris/pull/10199#issuecomment-1162614710
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 merged pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10199:
URL: https://github.com/apache/doris/pull/10199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10199:
URL: https://github.com/apache/doris/pull/10199#discussion_r900062700
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostCalculator.java:
##########
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.analysis.SlotId;
+import org.apache.doris.nereids.OperatorVisitor;
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalAggregation;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Calculate the cost of a plan.
+ * Inspired by Presto.
+ */
+public class CostCalculator {
+ /**
+ * Constructor.
+ */
+ public double calculateCost(GroupExpression groupExpression) {
+ PlanContext planContext = new PlanContext(groupExpression);
+ CostEstimator costCalculator = new CostEstimator();
+ CostEstimate costEstimate = groupExpression.getOperator()
+ .accept(costCalculator, planContext);
+ return costFormula(costEstimate);
+ }
+
+ private double costFormula(CostEstimate costEstimate) {
+ double cpuCostWeight = 1;
+ double memoryCostWeight = 1;
+ double networkCostWeight = 1;
+ return costEstimate.getCpuCost() * cpuCostWeight + costEstimate.getMemoryCost() * memoryCostWeight
+ + costEstimate.getNetworkCost() * networkCostWeight;
+ }
+
+ private static class CostEstimator extends OperatorVisitor<CostEstimate, PlanContext> {
+ @Override
+ public CostEstimate visitOperator(Operator operator, PlanContext context) {
+ return CostEstimate.zero();
+ }
+
+ @Override
+ public CostEstimate visitPhysicalAggregation(PhysicalAggregation physicalAggregation, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalOlapScan(PhysicalOlapScan physicalOlapScan, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalHashJoin(PhysicalHashJoin physicalHashJoin, PlanContext context) {
+ Preconditions.checkState(context.getGroupExpression().arity() == 2);
+ Preconditions.checkState(context.getChildrenStats().size() == 2);
+
+ StatsDeriveResult leftStatistics = context.getChildStatistics(0);
+ StatsDeriveResult rightStatistics = context.getChildStatistics(1);
+
+ // TODO: handle some case
+
+ List<SlotId> leftIds = context.getChildOutputSlots(0).stream().map(Slot::getId).map(SlotId::create)
Review Comment:
id in Slot should use `ExprId` instead of a int literal
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostCalculator.java:
##########
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.analysis.SlotId;
+import org.apache.doris.nereids.OperatorVisitor;
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalAggregation;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Calculate the cost of a plan.
+ * Inspired by Presto.
+ */
+public class CostCalculator {
+ /**
+ * Constructor.
+ */
+ public double calculateCost(GroupExpression groupExpression) {
+ PlanContext planContext = new PlanContext(groupExpression);
+ CostEstimator costCalculator = new CostEstimator();
+ CostEstimate costEstimate = groupExpression.getOperator()
+ .accept(costCalculator, planContext);
+ return costFormula(costEstimate);
+ }
+
+ private double costFormula(CostEstimate costEstimate) {
+ double cpuCostWeight = 1;
+ double memoryCostWeight = 1;
+ double networkCostWeight = 1;
+ return costEstimate.getCpuCost() * cpuCostWeight + costEstimate.getMemoryCost() * memoryCostWeight
+ + costEstimate.getNetworkCost() * networkCostWeight;
+ }
+
+ private static class CostEstimator extends OperatorVisitor<CostEstimate, PlanContext> {
+ @Override
+ public CostEstimate visitOperator(Operator operator, PlanContext context) {
+ return CostEstimate.zero();
+ }
+
+ @Override
+ public CostEstimate visitPhysicalAggregation(PhysicalAggregation physicalAggregation, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalOlapScan(PhysicalOlapScan physicalOlapScan, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalHashJoin(PhysicalHashJoin physicalHashJoin, PlanContext context) {
+ Preconditions.checkState(context.getGroupExpression().arity() == 2);
+ Preconditions.checkState(context.getChildrenStats().size() == 2);
+
+ StatsDeriveResult leftStatistics = context.getChildStatistics(0);
+ StatsDeriveResult rightStatistics = context.getChildStatistics(1);
+
+ // TODO: handle some case
+
+ List<SlotId> leftIds = context.getChildOutputSlots(0).stream().map(Slot::getId).map(SlotId::create)
+ .collect(Collectors.toList());
+ List<SlotId> rightIds = context.getChildOutputSlots(1).stream().map(Slot::getId).map(SlotId::create)
Review Comment:
StatsDeriveResult will be modified to adjust for Nereids. After that, it could use both SlotId and ExprId as Column key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10199:
URL: https://github.com/apache/doris/pull/10199#discussion_r900101891
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostCalculator.java:
##########
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.analysis.SlotId;
+import org.apache.doris.nereids.OperatorVisitor;
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalAggregation;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.operators.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Calculate the cost of a plan.
+ * Inspired by Presto.
+ */
+public class CostCalculator {
+ /**
+ * Constructor.
+ */
+ public double calculateCost(GroupExpression groupExpression) {
+ PlanContext planContext = new PlanContext(groupExpression);
+ CostEstimator costCalculator = new CostEstimator();
+ CostEstimate costEstimate = groupExpression.getOperator()
+ .accept(costCalculator, planContext);
+ return costFormula(costEstimate);
+ }
+
+ private double costFormula(CostEstimate costEstimate) {
+ double cpuCostWeight = 1;
+ double memoryCostWeight = 1;
+ double networkCostWeight = 1;
+ return costEstimate.getCpuCost() * cpuCostWeight + costEstimate.getMemoryCost() * memoryCostWeight
+ + costEstimate.getNetworkCost() * networkCostWeight;
+ }
+
+ private static class CostEstimator extends OperatorVisitor<CostEstimate, PlanContext> {
+ @Override
+ public CostEstimate visitOperator(Operator operator, PlanContext context) {
+ return CostEstimate.zero();
+ }
+
+ @Override
+ public CostEstimate visitPhysicalAggregation(PhysicalAggregation physicalAggregation, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalOlapScan(PhysicalOlapScan physicalOlapScan, PlanContext context) {
+ StatsDeriveResult statistics = context.getStatisticsWithCheck();
+ return CostEstimate.ofCpu(statistics.computeSize());
+ }
+
+ @Override
+ public CostEstimate visitPhysicalHashJoin(PhysicalHashJoin physicalHashJoin, PlanContext context) {
+ Preconditions.checkState(context.getGroupExpression().arity() == 2);
+ Preconditions.checkState(context.getChildrenStats().size() == 2);
+
+ StatsDeriveResult leftStatistics = context.getChildStatistics(0);
+ StatsDeriveResult rightStatistics = context.getChildStatistics(1);
+
+ // TODO: handle some case
+
+ List<SlotId> leftIds = context.getChildOutputSlots(0).stream().map(Slot::getId).map(SlotId::create)
Review Comment:
If you need to use the SlotId class, should you use this type directly in the Slot instead of doing type conversion here.
Secondly, at present, the SlotId class can be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #10199: [feature](nereids): cost and stats.
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10199:
URL: https://github.com/apache/incubator-doris/pull/10199#discussion_r899718349
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/statistics/StatisticsEstimate.java:
##########
@@ -0,0 +1,88 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost.statistics;
+
+/**
+ * Statistics.
+ */
+public class StatisticsEstimate {
Review Comment:
it is look like the same thing with our StatisticsDeriveResult?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/statistics/VariableStatsEstimate.java:
##########
@@ -0,0 +1,54 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost.statistics;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * VariableStatsEstimate.
+ */
+public class VariableStatsEstimate {
Review Comment:
also same thing with StatsDeriveResult？
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/statistics/StatisticRange.java:
##########
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost.statistics;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * Calculate range with statistics.
+ */
+public class StatisticRange {
Review Comment:
What is this class for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org