You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "AadityaAnand (via GitHub)" <gi...@apache.org> on 2026/08/03 03:17:45 UTC
[PR] Fix resample to zero across full query time range [superset]
AadityaAnand opened a new pull request, #42678:
URL: https://github.com/apache/superset/pull/42678
Summary
This PR fixes an issue where enabling Resample to zero only generated zero-filled buckets between the first and last data points returned by the query, rather than across the entire selected query time range.
The implementation propagates the resolved query time boundaries (from_dttm and to_dttm) into the pandas post-processing resampling step. When zero-fill resampling is enabled, the resampling now generates buckets for the full query time range, filling any missing intervals with 0.
Changes
* Pass the resolved query time range (from_dttm and to_dttm) from QueryObject to the resampling post-processing step.
* Extend zero-fill resampling to cover the entire selected query time range instead of only the range between existing data points.
* Preserve the existing behavior when no query time range is available.
* Leave all other resampling methods unchanged.
* Add unit tests covering:
* Single data point within the selected time range.
* Missing data at the beginning of the range.
* Missing data at the end of the range.
* Missing data throughout the range.
* Regression case verifying existing behavior when no query time range is provided.
Root Cause
The existing implementation relied on pandas.DataFrame.resample(...).asfreq(fill_value=0), which only generates buckets between the first and last timestamps present in the data. As a result, leading and trailing gaps within the selected query time range were never filled.
Testing
* Added unit tests for the new zero-fill behavior.
* Verified backward compatibility when no query time range is supplied.
* Confirmed that non-zero-fill resampling behavior remains unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5161939131
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5161992892
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42678?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `12.50000%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.85%. Comparing base ([`4915a3e`](https://app.codecov.io/gh/apache/superset/commit/4915a3e8c78a956d59b8e3e69669d2f9eefe779e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd534aa`](https://app.codecov.io/gh/apache/superset/commit/bd534aa00535d50a71fd5ce13d75132873b57b19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/42678?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/utils/pandas\_postprocessing/resample.py](https://app.codecov.io/gh/apache/superset/pull/42678?src=pr&el=tree&filepath=superset%2Futils%2Fpandas_postprocessing%2Fresample.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3Jlc2FtcGxlLnB5) | 16.66% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42678?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/common/query\_object.py](https://app.codecov.io/gh/apache/superset/pull/42678?src=pr&el=tree&filepath=superset%2Fcommon%2Fquery_object.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42678?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (4915a3e) and HEAD (bd534aa). Click for more details.
>
> <details><summary>HEAD has 112 uploads less than BASE</summary>
>
>| Flag | BASE (4915a3e) | HEAD (bd534aa) |
>|------|------|------|
>|python|98|1|
>|presto|16|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42678 +/- ##
==========================================
- Coverage 65.44% 55.85% -9.59%
==========================================
Files 2810 2810
Lines 159488 159495 +7
Branches 36403 36405 +2
==========================================
- Hits 104375 89086 -15289
- Misses 53069 69577 +16508
+ Partials 2044 832 -1212
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.96% <12.50%> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.96% <12.50%> (-19.27%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/42678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42678?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5179408384
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | a9ec51dc8e05134e7ec4d279621a485e5562f1e5 |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a71e19e0b2b000008b83e58 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-42678--superset-docs-preview.netlify.app](https://deploy-preview-42678--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#FYpBCoAgEAD_suckLSrrBz1Dcy1BU8ygiP7eNqeBmQdSjiEVmAAq0Fnty0Zu3VVnPFRIHpk9vWfFBWSUV6TPYPLxng2dvRoEihG5bjT_kVq22El4Pw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42678--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: extend zero-fill resampling to the full query time range [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5593250019
@AadityaAnand checking back in on this one. Still keen to get it in, just needs the off-grid origin case sadpandajoe flagged sorted out, plus a rebase on `master`. Holler if you'd like a hand with either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: extend zero-fill resampling to the full query time range [superset]
Posted by "AadityaAnand (via GitHub)" <gi...@apache.org>.
AadityaAnand commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5248412473
Anyone reviewing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #42678:
URL: https://github.com/apache/superset/pull/42678#discussion_r3701136814
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +55,18 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ origin = time_range_start if time_range_start is not None else "start_day"
+ _df = df.resample(rule, origin=origin).asfreq(fill_value=fill_value)
+ if time_range_start is not None and time_range_end is not None:
+ # Zero-filling should cover the entire queried time range, not
+ # just the span between the first and last existing data points.
+ full_index = pd.date_range(
+ start=time_range_start,
+ end=time_range_end,
+ freq=rule,
+ inclusive="left",
+ )
+ _df = _df.reindex(full_index, fill_value=fill_value)
Review Comment:
**Suggestion:** `pd.date_range` does not necessarily produce the same labels as `df.resample(rule)`, especially for calendar rules such as month-start, quarter-start, or year-start frequencies. With a query starting mid-month, a month-start resampler can produce the bucket labeled at the start of that month while `date_range(start=time_range_start, freq=rule)` starts at the next month; `reindex` then discards the real bucket and replaces it with zero-filled labels. Build the full index from the resampler's actual bucket alignment rather than independently generating it from the raw query start. [incorrect condition logic]
<details>
<summary><b>Severity Level:</b> Major β οΈ</summary>
```mdx
- β Month-start zero-fill charts can lose first-period data.
- β οΈ Calendar-based resampling labels differ from query results.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=efb8384d8e5b490489a03383e2aaa3b5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=efb8384d8e5b490489a03383e2aaa3b5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/pandas_postprocessing/resample.py
**Line:** 63:69
**Comment:**
*Incorrect Condition Logic: `pd.date_range` does not necessarily produce the same labels as `df.resample(rule)`, especially for calendar rules such as month-start, quarter-start, or year-start frequencies. With a query starting mid-month, a month-start resampler can produce the bucket labeled at the start of that month while `date_range(start=time_range_start, freq=rule)` starts at the next month; `reindex` then discards the real bucket and replaces it with zero-filled labels. Build the full index from the resampler's actual bucket alignment rather than independently generating it from the raw query start.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42678&comment_hash=293dae44a939268013662769a1fe0db66978219309c8b40c7626770b12a6e7f4&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42678&comment_hash=293dae44a939268013662769a1fe0db66978219309c8b40c7626770b12a6e7f4&reaction=dislike'>π</a>
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +55,18 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ origin = time_range_start if time_range_start is not None else "start_day"
+ _df = df.resample(rule, origin=origin).asfreq(fill_value=fill_value)
Review Comment:
**Suggestion:** Passing an aware query bound as `origin` to a resampler whose `DatetimeIndex` is naive, or vice versa, raises a pandas timezone-compatibility error. Query boundaries are commonly UTC-aware while database result indexes are not guaranteed to have timezone metadata. Normalize both bounds and the DataFrame index to compatible timezone awareness before resampling. [type error]
<details>
<summary><b>Severity Level:</b> Major β οΈ</summary>
```mdx
- β Timeseries queries with timezone offsets can return validation errors.
- β οΈ Zero-fill post-processing becomes dependent on index timezone metadata.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6e4bf68555ef4ec29724605b5f0aa466&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6e4bf68555ef4ec29724605b5f0aa466&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/pandas_postprocessing/resample.py
**Line:** 58:59
**Comment:**
*Type Error: Passing an aware query bound as `origin` to a resampler whose `DatetimeIndex` is naive, or vice versa, raises a pandas timezone-compatibility error. Query boundaries are commonly UTC-aware while database result indexes are not guaranteed to have timezone metadata. Normalize both bounds and the DataFrame index to compatible timezone awareness before resampling.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42678&comment_hash=b8902a57f93556174e4cef6df5987fb013165c026ccd27dc1046a78fa9eaff1a&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42678&comment_hash=b8902a57f93556174e4cef6df5987fb013165c026ccd27dc1046a78fa9eaff1a&reaction=dislike'>π</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "AadityaAnand (via GitHub)" <gi...@apache.org>.
AadityaAnand commented on code in PR #42678:
URL: https://github.com/apache/superset/pull/42678#discussion_r3712721818
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +55,18 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ origin = time_range_start if time_range_start is not None else "start_day"
+ _df = df.resample(rule, origin=origin).asfreq(fill_value=fill_value)
+ if time_range_start is not None and time_range_end is not None:
+ # Zero-filling should cover the entire queried time range, not
+ # just the span between the first and last existing data points.
+ full_index = pd.date_range(
+ start=time_range_start,
+ end=time_range_end,
+ freq=rule,
+ inclusive="left",
+ )
+ _df = _df.reindex(full_index, fill_value=fill_value)
Review Comment:
Thanks for the review. I updated the implementation to preserve the resamplerβs existing bucket labels while extending the index rather than replacing it. This avoids dropping legitimate buckets for calendar-based frequencies such as month, quarter, and year start. Regression tests have been added for these scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix resample to zero across full query time range [superset]
Posted by "AadityaAnand (via GitHub)" <gi...@apache.org>.
AadityaAnand commented on code in PR #42678:
URL: https://github.com/apache/superset/pull/42678#discussion_r3712718639
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +55,18 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ origin = time_range_start if time_range_start is not None else "start_day"
+ _df = df.resample(rule, origin=origin).asfreq(fill_value=fill_value)
Review Comment:
Thanks for catching this. I updated the implementation to normalize the query boundaries so they match the DataFrame indexβs timezone awareness before passing them to resample(). I also added regression tests covering timezone-aware and timezone-naive indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: extend zero-fill resampling to the full query time range [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5181542484
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: extend zero-fill resampling to the full query time range [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42678:
URL: https://github.com/apache/superset/pull/42678#issuecomment-5441677191
Thanks for tackling this, the test coverage here is solid. @sadpandajoe's thread on the off-grid origin case is still open and looks worthy of fixing. There are also conflicts with `master`. Let me know if you would like a hand with any of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: extend zero-fill resampling to the full query time range [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #42678:
URL: https://github.com/apache/superset/pull/42678#discussion_r3822342697
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +78,30 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ aligned_start = _align_time_range_tz(time_range_start, df.index)
+ aligned_end = _align_time_range_tz(time_range_end, df.index)
+ origin = aligned_start if aligned_start is not None else "start_day"
Review Comment:
When a query begins off the rule's normal grid (for example `00:15` with hourly source points at `01:00`), using that boundary as `origin` makes `asfreq()` drop the real points and returns only zero buckets at `00:15`, `01:15`, and `02:15`. Could this preserve the existing resample grid and extend a compatible fill index instead, with an unaligned-bound regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org