You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/12 15:54:33 UTC

[GitHub] caddac edited a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option

caddac edited a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option
URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-412351673
 
 
   @ashb @bolkedebruin  I've been working on refactoring the connection api and wanted to run the implementation by you before going too far. My thought is in `api/common/experimental/` there will be 4 files: `add_connection.py`, `list_connection.py`, `delete_connection.py`, `update_connection.py` where the DB access will occur. These functions will take explicitly defined arguments based on what they are doing (not dicts or something) and return `Connections` (or in the case of delete, `conn_id`(s)). 
   
   Then each client (cli, local, json) would be responsible for parsing arguments and constructing meaningful print/return statements to the user (e.g. the cli client would formulate the message `Successfully added `conn_id`={conn_id} : {uri}` where as the json client would just return http 200 and the connection as json). 
   
   thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services